Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resources: azurerm_mysql_* #352

Merged
merged 2 commits into from
Sep 27, 2017
Merged

New Resources: azurerm_mysql_* #352

merged 2 commits into from
Sep 27, 2017

Conversation

tombuildsstuff
Copy link
Contributor

Adding support for the Azure Database for MySQL resources:

  • azurerm_mysql_configuration
  • azurerm_mysql_database
  • azurerm_mysql_firewall_rule
  • azurerm_mysql_server

This PR:

  • Vendors the Azure SDK for Go MySQL SDK
  • Supporting MySQL Server / Database / Firewall Rule & Configuration management
  • Updated the SKU's/Capacities for PostgreSQL too
  • Fixes the highlight on the PostgreSQL documentation
  • Switching the automation resources over to using the new ResourceGroupNameSchema

@tombuildsstuff tombuildsstuff mentioned this pull request Sep 25, 2017
Closed
@tombuildsstuff
Copy link
Contributor Author

MySQL tests pass:

screen shot 2017-09-25 at 10 06 01

PostgreSQL tests pass:

screen shot 2017-09-25 at 10 06 05

mbfrahry
mbfrahry approved these changes Sep 26, 2017
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much here but it looks really clean. LGTM! Just have to fix the conflict.

@tombuildsstuff
Adding support for Azure Database for MySQL
bb584ff 
- Vendoring the Azure SDK for Go MySQL SDK
- Supporting MySQL Server / Database / Firewall Rule & Configuration management
- Updated the SKU's/Capacities for PostgreSQL too
- Fixes the highlight on the PostgreSQL documentation
- Switching the automation resources over to using the new ResourceGroupNameSchema
@tombuildsstuff
Fixing the rebase issue
744295d
@tombuildsstuff tombuildsstuff merged commit 1a3dab3 into master Sep 27, 2017
tombuildsstuff added a commit that referenced this pull request Sep 27, 2017
@tombuildsstuff
Updating to include #352
d520011
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbfrahry mbfrahry mbfrahry approved these changes

Assignees
No one assigned
Labels
enhancement new-resource
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tombuildsstuff @mbfrahry