-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update redux firewall rule name to allow underscores - resolves #2903 #2906
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for this @RiverPhillips
My update just simplifies the regex a little |
Thank you so much! As a side note, the PR I was going to send also added a new test case for the (valid) |
Thanks for another quick reviewal |
This PR simplifies the regex in redis firewall rule name (original merged pr is #2906 )
@RiverPhillips - Just a heads up to say I amended your regex to \w in PR #2911 |
@ghostinthewires Much nicer, didn't realise that was possible |
@RiverPhillips - No probs, theres loads of different options. You on Twitter? |
Newer version looks definitely better. Thanks, @ghostinthewires ! |
This has been released in version 1.23.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.23.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Update the regex validation to allow underscores in redux firewall rules, this is supported by azure