Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update redux firewall rule name to allow underscores - resolves #2903 #2906

Merged
merged 3 commits into from
Feb 18, 2019
Merged

Update redux firewall rule name to allow underscores - resolves #2903 #2906

merged 3 commits into from
Feb 18, 2019

Conversation

RiverPhillips
Copy link
Contributor

@RiverPhillips RiverPhillips commented Feb 17, 2019

Update the regex validation to allow underscores in redux firewall rules, this is supported by azure

@ghost ghost added the size/XS label Feb 17, 2019
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @RiverPhillips

@ghostinthewires
Copy link
Contributor

My update just simplifies the regex a little

@inkel
Copy link
Contributor

inkel commented Feb 18, 2019

Thank you so much! As a side note, the PR I was going to send also added a new test case for the (valid) _helloworld_ string.

@RiverPhillips
Copy link
Contributor Author

LGTM - thanks for this @RiverPhillips

Thanks for another quick reviewal

katbyte pushed a commit that referenced this pull request Feb 19, 2019
This PR simplifies the regex in redis firewall rule name (original merged pr is #2906 )
@ghostinthewires
Copy link
Contributor

@RiverPhillips - Just a heads up to say I amended your regex to \w in PR #2911

@RiverPhillips
Copy link
Contributor Author

@ghostinthewires Much nicer, didn't realise that was possible

@ghostinthewires
Copy link
Contributor

@RiverPhillips - No probs, theres loads of different options. You on Twitter?

@inkel
Copy link
Contributor

inkel commented Feb 19, 2019

Newer version looks definitely better. Thanks, @ghostinthewires !

@ghost
Copy link

ghost commented Mar 8, 2019

This has been released in version 1.23.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.23.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 20, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants