Fix Keyvault network ACL with multiple subnet ids #2324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vider-azurerm into fix-keyvault-multiple-subnet-ids
leonfs
changed the title
tombuildsstuff
approved these changes
Nov 19, 2018
|
Ignoring a known/transient test failure, tests pass:
|
tombuildsstuff
added a commit
that referenced
this pull request
Nov 19, 2018
|
My pleasure @tombuildsstuff. I took it as an opportunity to try out the new Go modules. Initialising the project as a module and running the tests worked at the first attempt, great surprise. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2129
I first added an integration test that reproduced the error by adding a new subnet to the Key Vault network ACL list. The test that creates it has two subnets, while there is another test that updates to go back to one subnet.
The function
sliceContainsValueused to fix the problem, has also been previously used throughout the code base for similar scenarios.