New Resources: azurerm_subnet_network_security_group_association / azurerm_subnet_route_table_association
#1933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombuildsstuff
force-pushed
the
subnet-associations
branch
from
2b79a3b
to
14498fe
Compare
tombuildsstuff
force-pushed
the
subnet-associations
branch
from
14498fe
to
b4f271f
Compare
``` $ acctests azurerm TestAccAzureRMSubnetRouteTableAssociation === RUN TestAccAzureRMSubnetRouteTableAssociation_basic --- PASS: TestAccAzureRMSubnetRouteTableAssociation_basic (145.86s) === RUN TestAccAzureRMSubnetRouteTableAssociation_deleted --- PASS: TestAccAzureRMSubnetRouteTableAssociation_deleted (103.94s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 250.163s ```
``` $ acctests azurerm TestAccAzureRMSubnetNetworkSecurityGroupAssociation_ === RUN TestAccAzureRMSubnetNetworkSecurityGroupAssociation_basic --- PASS: TestAccAzureRMSubnetNetworkSecurityGroupAssociation_basic (129.21s) === RUN TestAccAzureRMSubnetNetworkSecurityGroupAssociation_deleted --- PASS: TestAccAzureRMSubnetNetworkSecurityGroupAssociation_deleted (99.74s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 229.367s ```
tombuildsstuff
force-pushed
the
subnet-associations
branch
from
b4f271f
to
a559773
Compare
|
Tests pass:
|
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two new Virtual Resources for linking Subnets to Network Security Groups (
azurerm_subnet_network_security_group_association) and Route Tables (azurerm_subnet_route_table_association). As a part of this PR, the fieldsroute_table_idandnetwork_security_group_idwithin theazurerm_subnetresource have been made Computed (to allow them to be set via the new resource) and Deprecated (in favour of the new resources).Separating these associations out from the main Subnet resource means we no longer have to check the config during the deletion (which may not be present) - such that this should alleviate some hard to reproduce deletion bugs.