Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppInsights: working around a breaking API change. #1769

Merged
merged 1 commit into from
Aug 15, 2018

Conversation

tombuildsstuff
Copy link
Contributor

The Application Insights API has started returning a HTTP 201 instead of a HTTP 200 (as is documented in the Swagger and thus used in the SDK) from ~2018-08-14 onwards; this PR works around this issue - which has been raised with MS here: Azure/azure-sdk-for-go#2465

Fixes #1762

@tombuildsstuff
Copy link
Contributor Author

Tests pass:

screenshot 2018-08-15 at 12 19 38

@tombuildsstuff tombuildsstuff merged commit 611746e into master Aug 15, 2018
@tombuildsstuff tombuildsstuff deleted the appinsights-api-bug branch August 15, 2018 10:20
tombuildsstuff added a commit that referenced this pull request Aug 15, 2018
@liamfoneill
Copy link

liamfoneill commented Aug 15, 2018

How do we start using this straight away? The App Insights API change a big breaking change for our env and we need to start using a provider with this PR asap. Do we have to wait until 1.13 or can you release a bug fix version of the provider?

@tombuildsstuff
Copy link
Contributor Author

@liamfoneill as this is a breaking change we'll be doing a release later today - should you need to do this in the meantime you can compile the provider from source (details are in the README) - there's also an upstream change requesting the API's rolled back here:
Azure/azure-sdk-for-go#2465

@liamfoneill
Copy link

Great thank you Tom. I shall await the release

@tombuildsstuff
Copy link
Contributor Author

hi @liamfoneill @scotm-gxg

Just to let you know that a fix for this issue has been released as part of v1.13.0 of the AzureRM Provider :)

Thanks!

@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_application_insights - failure on create or update actions
3 participants