-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppInsights: working around a breaking API change. #1769
Conversation
How do we start using this straight away? The App Insights API change a big breaking change for our env and we need to start using a provider with this PR asap. Do we have to wait until 1.13 or can you release a bug fix version of the provider? |
@liamfoneill as this is a breaking change we'll be doing a release later today - should you need to do this in the meantime you can compile the provider from source (details are in the README) - there's also an upstream change requesting the API's rolled back here: |
Great thank you Tom. I shall await the release |
Just to let you know that a fix for this issue has been released as part of v1.13.0 of the AzureRM Provider :) Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
The Application Insights API has started returning a HTTP 201 instead of a HTTP 200 (as is documented in the Swagger and thus used in the SDK) from ~2018-08-14 onwards; this PR works around this issue - which has been raised with MS here: Azure/azure-sdk-for-go#2465
Fixes #1762