Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IoTHub: support for the Basic SKU #1717

Merged
merged 1 commit into from
Aug 3, 2018
Merged

IoTHub: support for the Basic SKU #1717

merged 1 commit into from
Aug 3, 2018

Conversation

tombuildsstuff
Copy link
Contributor

The Basic SKU is now available in version 2018-04-01 of the IoTHub API - this PR updates to this version of the SDK and adds the property

cc @echuvyrov

@tombuildsstuff tombuildsstuff requested a review from a team August 3, 2018 08:41
@tombuildsstuff tombuildsstuff added this to the 1.13.0 milestone Aug 3, 2018
@tombuildsstuff
Copy link
Contributor Author

Tests pass:

$ acctests azurerm TestAccAzureRMIotHub_

=== RUN   TestAccAzureRMIotHub_importBasic
--- PASS: TestAccAzureRMIotHub_importBasic (139.64s)
=== RUN   TestAccAzureRMIotHub_importStandard
--- PASS: TestAccAzureRMIotHub_importStandard (241.72s)
=== RUN   TestAccAzureRMIotHub_basic
--- PASS: TestAccAzureRMIotHub_basic (197.14s)
=== RUN   TestAccAzureRMIotHub_standard
--- PASS: TestAccAzureRMIotHub_standard (125.13s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	703.986s

@tombuildsstuff tombuildsstuff merged commit 0334869 into master Aug 3, 2018
@tombuildsstuff tombuildsstuff deleted the iothub-basic branch August 3, 2018 14:06
tombuildsstuff added a commit that referenced this pull request Aug 3, 2018
@tombuildsstuff
Updating to include #1717
c4f85b1
@tombuildsstuff
Copy link
Contributor Author

tombuildsstuff commented Aug 15, 2018 •
edited
Loading

hey @echuvyrov

Just to let you know that we've just shipped support for this as a part of v1.13.0 of the AzureRM Provider :)

Thanks!

@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paultyng paultyng paultyng approved these changes

Assignees
No one assigned
Labels
enhancement service/iot-hub
Projects
None yet
Milestone
v1.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tombuildsstuff @paultyng