Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new resource - azurerm_eventhub_namespace_authorization_rule #1572

Merged
merged 8 commits into from
Jul 16, 2018

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Jul 13, 2018

No description provided.

@katbyte katbyte added this to the 1.10.0 milestone Jul 13, 2018
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM 👍


# azurerm_eventhub_namespace_authorization_rule

Manages a Event Hub Namespace authorization Rule within an Event Hub.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manages a Event Hub Namespace authorization Rule within an Event Hub. -> Manages an Authorization Rule for an EventHub Namespace

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noticed a couple of bugs in the tests

}

func testCheckAzureRMEventHubNamespaceAuthorizationRuleDestroy(s *terraform.State) error {
conn := testAccProvider.Meta().(*ArmClient).eventHubClient
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this wants to be using the Namespaces client

return fmt.Errorf("Bad: no resource group found in state for Event Hub: %s", name)
}

conn := testAccProvider.Meta().(*ArmClient).eventHubClient
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this wants to be using the Namespaces client

@tombuildsstuff
Copy link
Contributor

Tests pass:

screenshot 2018-07-16 at 16 54 22

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit 297b365 into master Jul 16, 2018
@tombuildsstuff tombuildsstuff deleted the f-eventhub-authrules branch July 16, 2018 14:55
tombuildsstuff added a commit that referenced this pull request Jul 16, 2018
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants