Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: azurerm_data_lake_store_firewall_rule #1499

Merged
merged 2 commits into from
Jul 10, 2018
Merged

New Resource: azurerm_data_lake_store_firewall_rule #1499

merged 2 commits into from
Jul 10, 2018

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Jul 5, 2018 •
edited
Loading

Adding support for Firewall Rules on Data Lake Store's

Acceptance Tests:

$ acctests azurerm TestAccAzureRMDataLakeStoreFirewallRule_
=== RUN   TestAccAzureRMDataLakeStoreFirewallRule_basic
--- PASS: TestAccAzureRMDataLakeStoreFirewallRule_basic (127.61s)
=== RUN   TestAccAzureRMDataLakeStoreFirewallRule_update
--- PASS: TestAccAzureRMDataLakeStoreFirewallRule_update (251.35s)
=== RUN   TestAccAzureRMDataLakeStoreFirewallRule_azureServices
--- PASS: TestAccAzureRMDataLakeStoreFirewallRule_azureServices (147.05s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	526.054s

@tombuildsstuff tombuildsstuff force-pushed the datalake-firewall-rules branch from fc73946 to c392242 Compare July 5, 2018 18:31
@tombuildsstuff tombuildsstuff requested a review from a team July 5, 2018 18:43
katbyte
katbyte approved these changes Jul 9, 2018
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @tombuildsstuff 👍

@katbyte katbyte added this to the 1.9.0 milestone Jul 10, 2018
@katbyte
Copy link
Collaborator

katbyte commented Jul 10, 2018

tests pass:
screen shot 2018-07-09 at 17 09 57

@katbyte katbyte merged commit c1f4b36 into master Jul 10, 2018
@katbyte katbyte deleted the datalake-firewall-rules branch July 10, 2018 00:10
katbyte added a commit that referenced this pull request Jul 10, 2018
@katbyte
Update CHANGELOG.md to include #1499
d676869
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
new-resource service/data-lake
Projects
None yet
Milestone
v1.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tombuildsstuff @katbyte