AKS: NetworkProfile / Advanced Networking

[lfshr]

Added network_profile to kubernetes_cluster resource.
#1389 #1434

[lfshr]

@tombuildsstuff I couldn't get the tests running properly (wouldn't fail when it should have), may need some assistance here. Also think I should merge the two tests into one. This is just the resource. If you want me to include the data source here, let me know. Otherwise I'll open up another PR for it. 😄

Also.. Check my networking. Not one of my strong points! 😛

[lfshr]

@tombuildsstuff the resource and data source is good to review. Just about to add an example into the examples.

Be harsh! 👍

[lfshr]

Result from pinging node agent from another vm within the same vnet:

liam@test-networking:~$ ping 10.1.0.35
PING 10.1.0.35 (10.1.0.35) 56(84) bytes of data.
64 bytes from 10.1.0.35: icmp_seq=1 ttl=64 time=1.50 ms
64 bytes from 10.1.0.35: icmp_seq=2 ttl=64 time=0.853 ms
64 bytes from 10.1.0.35: icmp_seq=3 ttl=64 time=0.787 ms
64 bytes from 10.1.0.35: icmp_seq=4 ttl=64 time=2.14 ms
64 bytes from 10.1.0.35: icmp_seq=5 ttl=64 time=0.884 ms
64 bytes from 10.1.0.35: icmp_seq=6 ttl=64 time=0.752 ms
64 bytes from 10.1.0.35: icmp_seq=7 ttl=64 time=0.730 ms
64 bytes from 10.1.0.35: icmp_seq=8 ttl=64 time=0.692 ms
64 bytes from 10.1.0.35: icmp_seq=9 ttl=64 time=0.682 ms
64 bytes from 10.1.0.35: icmp_seq=10 ttl=64 time=0.893 ms
64 bytes from 10.1.0.35: icmp_seq=11 ttl=64 time=0.745 ms

Nothing more satisfying 😄

[lfshr]

@tombuildsstuff did you look at my above comments? The error you're receiving on the serviceCidr is a non-descriptive error. See Azure/AKS#506
The above ARM template will not work. You need to supply the subnetId inside agentPoolProfile and the serviceCidr must be within this subnet.

[tombuildsstuff]

@lfshr I read the first two links but missed the third, apologies. I'd suggest we reply within those specific issues to work around the lack of threading here?

You need to supply the subnetId inside agentPoolProfile and the serviceCidr must be within this subnet.

🤦‍♂️ good spot - I'll re-test that now

[tombuildsstuff]

@lfshr cool, so I can confirm setting that works. Given I've made those changes locally, I'm going to commit them (and then also add a couple more for acceptance tests for both the Azure network profile & the Kubenet network profile; and some validation to work around Azure/AKS#506) - so that we can run the tests and ship this (I hope you don't mind!)

@metacpp thanks for the heads up :)

[lfshr]

@tombuildsstuff not at all. Do what you need to do. Anything you need from my end?

[metacpp]

@lfshr @tombuildsstuff You can see all my changes on top of @lfshr 's branch:
https://github.com/lfshr/terraform-provider-azurerm/pull/2/files

1. It bypasses the validation error.
2. It resolves the rerun of terraform plan.

It's just a reference. :-)

[tombuildsstuff]

Resource Tests pass:

Data Source tests pass:

[tombuildsstuff]

@lfshr nope, all good - the tests pass :) Thanks again for this PR - apologies for the confusion here.

[metacpp]

@tombuildsstuff what're the conclusions here?

[giggio]

Do we know when is 1.12 expected?

[tombuildsstuff]

@giggio we don't give exact dates since things can change - but I have a feeling it'll probably be next week at this point.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!