Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for azurerm_mysql_database resource wants to re-create on every apply #1281

Merged
merged 2 commits into from
May 24, 2018

Conversation

WodansSon
Copy link
Collaborator

Fix for casing issue in MySQL, issue #1183

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @jeffreyCline

Thanks for this PR - this LGTM, however can we add an acceptance test checking that setting the charset in upper-case results works? Adding this test will automatically check there's no difference in casing, which proves this works.

Thanks!

@tombuildsstuff tombuildsstuff modified the milestones: Soon, 1.6.0 May 23, 2018
@WodansSon WodansSon dismissed tombuildsstuff’s stale review May 23, 2018 21:37

Added two test cases to validate charset casing issue

@WodansSon
Copy link
Collaborator Author

@tombuildsstuff Sure, I added two test cases one with uppercase and another with mixed case. I have attached the test results of the test.

Test Results

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit 90d7ed5 into master May 24, 2018
@tombuildsstuff tombuildsstuff deleted the b-mysql-charset branch May 24, 2018 06:55
tombuildsstuff added a commit that referenced this pull request May 24, 2018
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants