-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App Service: moving ip_restrictions
within site_config
block
#1246
Conversation
``` $ acctests azurerm TestAccAzureRMAppServiceSlot_oneIpRestriction === RUN TestAccAzureRMAppServiceSlot_oneIpRestriction --- PASS: TestAccAzureRMAppServiceSlot_oneIpRestriction (176.90s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 176.925s ``` ``` $ acctests azurerm TestAccAzureRMAppServiceSlot_manyIpRestrictions === RUN TestAccAzureRMAppServiceSlot_manyIpRestrictions --- PASS: TestAccAzureRMAppServiceSlot_manyIpRestrictions (173.68s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 173.717s ```
b99ebcb
to
84cba44
Compare
84cba44
to
adb5597
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any particular reason we can't/shouldn't/needn't maintain ip_restrictions
on the 1st level still as "Deprecated" and keep it working for a couple of versions?
@radeksimko support for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I didn't know that - LGTM then!
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ip_restriction
to App Service Slotsip_restriction
within thesite_config
block - since it's Site specific