Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Service: moving ip_restrictions within site_config block #1246

Merged
merged 4 commits into from
May 24, 2018

Conversation

tombuildsstuff
Copy link
Contributor

  • Combining the Site Config from App Service (Data Sources & Resources) & App Service Slots
  • Added support for ip_restriction to App Service Slots
  • Moved ip_restriction within the site_config block - since it's Site specific

```
$ acctests azurerm TestAccAzureRMAppServiceSlot_oneIpRestriction
=== RUN   TestAccAzureRMAppServiceSlot_oneIpRestriction
--- PASS: TestAccAzureRMAppServiceSlot_oneIpRestriction (176.90s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	176.925s
```
```
$ acctests azurerm TestAccAzureRMAppServiceSlot_manyIpRestrictions
=== RUN   TestAccAzureRMAppServiceSlot_manyIpRestrictions
--- PASS: TestAccAzureRMAppServiceSlot_manyIpRestrictions (173.68s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	173.717s
```
@tombuildsstuff
Copy link
Contributor Author

Tests pass:

screen shot 2018-05-23 at 13 54 02

@tombuildsstuff tombuildsstuff requested a review from radeksimko May 24, 2018 06:56
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any particular reason we can't/shouldn't/needn't maintain ip_restrictions on the 1st level still as "Deprecated" and keep it working for a couple of versions?

@tombuildsstuff
Copy link
Contributor Author

@radeksimko support for ip_restrictions was only merged recently (and hasn't made it out to a release yet) - as such I don't feel we need to do a migration for that?

Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I didn't know that - LGTM then!

@tombuildsstuff tombuildsstuff merged commit 2f081ac into master May 24, 2018
@tombuildsstuff tombuildsstuff deleted the r-app-service branch May 24, 2018 12:39
tombuildsstuff added a commit that referenced this pull request May 24, 2018
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants