Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_relay_namespace #1233

Merged
merged 3 commits into from
May 14, 2018
Merged

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented May 14, 2018

This PR adds a new resource for managing Azure Relay Namespaces

Resource Tests pass:

$ acctests azurerm TestAccAzureRMRelayNamespace_
=== RUN   TestAccAzureRMRelayNamespace_basic
--- PASS: TestAccAzureRMRelayNamespace_basic (154.19s)
=== RUN   TestAccAzureRMRelayNamespace_complete
--- PASS: TestAccAzureRMRelayNamespace_complete (148.58s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	302.825s

Import tests:

$ acctests azurerm TestAccAzureRMRelayNamespace_import
=== RUN   TestAccAzureRMRelayNamespace_importBasic
--- PASS: TestAccAzureRMRelayNamespace_importBasic (194.74s)
=== RUN   TestAccAzureRMRelayNamespace_importComplete
--- PASS: TestAccAzureRMRelayNamespace_importComplete (164.46s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	359.235s

Fixes #1036

```
$ acctests azurerm TestAccAzureRMRelayNamespace_
=== RUN   TestAccAzureRMRelayNamespace_basic
--- PASS: TestAccAzureRMRelayNamespace_basic (154.19s)
=== RUN   TestAccAzureRMRelayNamespace_complete
--- PASS: TestAccAzureRMRelayNamespace_complete (148.58s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	302.825s
```

Import tests:

```
$ acctests azurerm TestAccAzureRMRelayNamespace_import
=== RUN   TestAccAzureRMRelayNamespace_importBasic
--- PASS: TestAccAzureRMRelayNamespace_importBasic (194.74s)
=== RUN   TestAccAzureRMRelayNamespace_importComplete
--- PASS: TestAccAzureRMRelayNamespace_importComplete (164.46s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	359.235s
```
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tombuildsstuff tombuildsstuff merged commit af7b7e5 into master May 14, 2018
@tombuildsstuff tombuildsstuff deleted the relay-namespace branch May 14, 2018 21:04
tombuildsstuff added a commit that referenced this pull request May 14, 2018
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Support for Azure Relay
2 participants