Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_virtual_network - removing crash points #1208

Merged
merged 2 commits into from
May 7, 2018

Conversation

tombuildsstuff
Copy link
Contributor

Nil-checking before accessing the properties

Fixes #1196

@tombuildsstuff tombuildsstuff added this to the 1.5.0 milestone May 6, 2018
@tombuildsstuff tombuildsstuff requested a review from a team May 6, 2018 19:50
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from one minor comment


if props := subnet.SubnetPropertiesFormat; props != nil {
if prefix := props.AddressPrefix; prefix != nil {
output["address_prefix"] = *props.AddressPrefix
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you could go output["address_prefix"] = *prefix here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 fixed

@tombuildsstuff
Copy link
Contributor Author

Tests pass:

screen shot 2018-05-07 at 06 39 38

@tombuildsstuff tombuildsstuff merged commit 2986e41 into master May 7, 2018
@tombuildsstuff tombuildsstuff deleted the b-virtual-network-crash branch May 7, 2018 13:40
tombuildsstuff added a commit that referenced this pull request May 7, 2018
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform crash while trying to import remote existing resources to state for Azure
2 participants