Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_data_factory_dataset_delimited_text - supports the azure_blob_fs_location property #12041

Merged
merged 1 commit into from
Jun 10, 2021

Conversation

njuCZ
Copy link
Contributor

@njuCZ njuCZ commented Jun 3, 2021

azurerm_data_factory_dataset_delimited_text supports different location, this PR supports storage data lake gen2 file system location.

image

@ghost ghost added size/L labels Jun 3, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we have some tst failures:

------- Stdout: -------
=== RUN   TestAccDataFactoryDatasetDelimitedText_blobFS
=== PAUSE TestAccDataFactoryDatasetDelimitedText_blobFS
=== CONT  TestAccDataFactoryDatasetDelimitedText_blobFS
    testing.go:620: Step 1/2 error: Error running apply: exit status 1
        
        Error: Provider produced inconsistent result after apply
        
        When applying changes to azurerm_role_assignment.test, provider
        "provider[\"registry.terraform.io/hashicorp/azurerm\"]" produced an
        unexpected new value: Root resource was present, but now absent.
        
        This is a bug in the provider, which should be reported in the provider's own
        issue tracker.
--- FAIL: TestAccDataFactoryDatasetDelimitedText_blobFS (150.55s)
FAIL

------- Stderr: -------
2021/06/03 16:50:38 [DEBUG] not using binary driver name, it's no longer needed
2021/06/03 16:50:39 [DEBUG] not using binary driver name, it's no longer needed

@njuCZ
Copy link
Contributor Author

njuCZ commented Jun 7, 2021

@katbyte I am sorry that merging the PR #11848 casued a role assignment issue, which made the acctest of this PR failed. There is a community PR #12076 fixing this issue. After that PR is merged, we could rerun the failed acctest

@katbyte katbyte changed the title azurerm_data_factory_dataset_delimited_text - supports storage data lake gen2 file system location azurerm_data_factory_dataset_delimited_text - supports the azure_blob_fs_location property Jun 10, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @njuCZ - LGTM 👍

@katbyte katbyte added this to the v2.63.0 milestone Jun 10, 2021
@katbyte katbyte merged commit 0dd2a1b into hashicorp:master Jun 10, 2021
katbyte added a commit that referenced this pull request Jun 10, 2021
@ghost
Copy link

ghost commented Jun 11, 2021

This has been released in version 2.63.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.63.0"
}
# ... other configuration ...

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants