Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_kubernetes_cluster: Support update of azure_rbac_enabled #12029

Merged

Conversation

aristosvo
Copy link
Contributor

Remove ForceNew from azure_rbac_enabled as feature is GA.

Acceptance Tests

❯ make acctests SERVICE='containers' TESTARGS='-run=TestAccKubernetesCluster_roleBasedAccessControlAzure'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./azurerm/internal/services/containers -run=TestAccKubernetesCluster_roleBasedAccessControlAzure -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
2021/06/01 12:51:01 [DEBUG] not using binary driver name, it's no longer needed
2021/06/01 12:51:03 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccKubernetesCluster_roleBasedAccessControlAzure
=== PAUSE TestAccKubernetesCluster_roleBasedAccessControlAzure
=== CONT  TestAccKubernetesCluster_roleBasedAccessControlAzure
--- PASS: TestAccKubernetesCluster_roleBasedAccessControlAzure (1354.18s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/containers     1358.813s

@ghost ghost added the size/XS label Jun 1, 2021
@aristosvo aristosvo changed the title kubernetes_cluster: Allow update of azure_rbac_enabled kubernetes_cluster: Support update of azure_rbac_enabled Jun 1, 2021
@aristosvo aristosvo force-pushed the feature/update-cluster-azure-rbac branch from fa92db6 to 7c2a07e Compare June 1, 2021 19:53
@ghost ghost added the documentation label Jun 2, 2021
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry changed the title kubernetes_cluster: Support update of azure_rbac_enabled azurerm_kubernetes_cluster: Support update of azure_rbac_enabled Jun 2, 2021
@mbfrahry mbfrahry merged commit 78298ed into hashicorp:master Jun 2, 2021
@mbfrahry mbfrahry added this to the v2.62.0 milestone Jun 2, 2021
mbfrahry added a commit that referenced this pull request Jun 2, 2021
@ghost
Copy link

ghost commented Jun 4, 2021

This has been released in version 2.62.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.62.0"
}
# ... other configuration ...

@github-actions
Copy link

github-actions bot commented Jul 5, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants