Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eventhub: refactoring on top of the generated SDK #11973

Merged
merged 12 commits into from
May 27, 2021
Merged

Conversation

tombuildsstuff
Copy link
Contributor

Similar to #11959, this PR refactors the eventhub package atop a Go SDK generated from the Azure Rest API Specs - providing an SDK similar to (and using the same foundation as) the Azure SDK for Go with some Terraform specifics built-in.

@tombuildsstuff tombuildsstuff added this to the v2.61.0 milestone May 26, 2021
@tombuildsstuff tombuildsstuff requested a review from a team May 26, 2021 16:42
@ghost ghost added the size/XXL label May 26, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tombuildsstuff tombuildsstuff merged commit 7d4c078 into master May 27, 2021
@tombuildsstuff tombuildsstuff deleted the f/eventhub-sdk branch May 27, 2021 14:45
tombuildsstuff added a commit that referenced this pull request May 27, 2021
@ghost
Copy link

ghost commented May 27, 2021

This has been released in version 2.61.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.61.0"
}
# ... other configuration ...

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants