"azurerm_spring_cloud_service" - supports property "required_network_traffic_rules" #11633
Conversation
ghost
added
azurerm/internal/services/springcloud/spring_cloud_service_resource.go
Outdated
Show resolved
Hide resolved
| @@ -158,6 +158,22 @@ The following attributes are exported: | |||
|
|
|||
| * `outbound_public_ip_addresses` - A list of the outbound Public IP Addresses used by this Spring Cloud Service. | |||
|
|
|||
| * `required_traffic` - A list of `required_traffic` blocks as defined below. | |||
There was a problem hiding this comment.
what does required traffic mean? is there a better more clear name for this property?
There was a problem hiding this comment.
according to the service team's explanation, some users want to limit the traffic of spring cloud app, but when spring cloud service is integrated with virtual network, there are some essential network trafiic that must be enabled. Users could put these into white list or firewall rules.
There was a problem hiding this comment.
so these are firewall_required_access_rules? or firewall_required_access?
There was a problem hiding this comment.
Hi @katbyte , the reason why we don't want to put "firewall" keyword in this property, is that Azure offers another service "network security group" which basically could do the similar job of allowing/denying traffic, and many customers are using it to secure their network. We don't want to have the "firewall" keyword in property name, which might be potentially misleading. Thanks.
There was a problem hiding this comment.
In that case I think the current name required_traffic is a better fit than required_access since:
- those are network configuration, not authorization
- the name aligns our API/SDK and will reduce confusion.
@katbyte what do you think?
There was a problem hiding this comment.
required_traffic is rather vague and is confusing, if it can be used elsewhere then maybe it should be required_network_access or even required_network so it reads like required_network.port
There was a problem hiding this comment.
required_network.direction looked strange to me so how about required_traffic_rules?
There was a problem hiding this comment.
your not wrong, i think its traffic without a qualifier that stands out to me, split the difference with required_network_traffic_rules? 🙃
njuCZ
changed the title
|
@katbyte thanks for your suggestion, I have renamed to |
|
This has been released in version 2.60.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.60.0"
}
# ... other configuration ... |
…traffic_rules" (hashicorp#11633) * "azurerm_spring_cloud_service" - supports property "required_traffic" * update * renamed to `required_network_traffic_rules`
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
this is a readonly property.
It lists the required traffic in virtual network mode.
some users want to limit spring cloud app's traffic, the "required_traffic" tells users which traffic must be enabled.