Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_cosmosdb_account_resource - marking connection_string as sensitive #10942

Merged
merged 2 commits into from
Mar 16, 2021

Conversation

stevematney
Copy link
Contributor

I believe this will resolve #10941, but I've never written Go or worked on a tf provider before.

@ghost ghost added the size/XS label Mar 12, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stevematney! LGTM 👍

@katbyte katbyte added this to the v2.52.0 milestone Mar 16, 2021
@katbyte katbyte changed the title Adding "Sensitive: true" to connection_string elements. azurerm_cosmosdb_account_resource - marking connection_string as sensitive Mar 16, 2021
@katbyte katbyte merged commit 32cab47 into hashicorp:master Mar 16, 2021
katbyte added a commit that referenced this pull request Mar 16, 2021
@ghost
Copy link

ghost commented Mar 18, 2021

This has been released in version 2.52.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.52.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 15, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_cosmos_db_account exposes connection strings in plaintext when directly accessed.
2 participants