Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_key_vault_access_policy - Fix destroy where permissions casing does not match config / state #10931

Merged
merged 4 commits into from
Mar 11, 2021

Conversation

jackofallops
Copy link
Member

fixes #10707

@jackofallops jackofallops added this to the v2.51.0 milestone Mar 11, 2021
@jackofallops jackofallops requested a review from a team March 11, 2021 09:05
@jackofallops jackofallops self-assigned this Mar 11, 2021
@ghost ghost added the size/M label Mar 11, 2021
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jackofallops
Copy link
Member Author

Tests looking good:
image

@jackofallops jackofallops merged commit b11bfc7 into master Mar 11, 2021
@jackofallops jackofallops deleted the b/keyvault-access-policy-delete-bug branch March 11, 2021 11:59
jackofallops added a commit that referenced this pull request Mar 11, 2021
@ghost
Copy link

ghost commented Mar 12, 2021

This has been released in version 2.51.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.51.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 10, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to destroy azurerm_key_vault and associated azurerm_key_vault_access_policy (30 minute timeout)
2 participants