Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/azurerm_kusto_eventhub_data_connection: allow for empty table_name and data_format #10913

Merged
merged 2 commits into from
Mar 10, 2021
Merged

r/azurerm_kusto_eventhub_data_connection: allow for empty table_name and data_format #10913

merged 2 commits into from
Mar 10, 2021

Conversation

favoretti
Copy link
Collaborator

Fixes #10838

$ make acctests SERVICE='kusto' TESTARGS='-run=TestAccKustoEventHubDataConnection_unbound' TESTTIMEOUT='600m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./azurerm/internal/services/kusto -run=TestAccKustoEventHubDataConnection_unbound -timeout 600m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
2021/03/10 09:45:41 [DEBUG] not using binary driver name, it's no longer needed
2021/03/10 09:45:41 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccKustoEventHubDataConnection_unboundMapping1
=== PAUSE TestAccKustoEventHubDataConnection_unboundMapping1
=== RUN   TestAccKustoEventHubDataConnection_unboundMapping2
=== PAUSE TestAccKustoEventHubDataConnection_unboundMapping2
=== CONT  TestAccKustoEventHubDataConnection_unboundMapping1
=== CONT  TestAccKustoEventHubDataConnection_unboundMapping2
--- PASS: TestAccKustoEventHubDataConnection_unboundMapping1 (1574.67s)
--- PASS: TestAccKustoEventHubDataConnection_unboundMapping2 (1747.31s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/kusto	1748.615s

…and data_format

Fixes #10838

```
$ make acctests SERVICE='kusto' TESTARGS='-run=TestAccKustoEventHubDataConnection_unbound' TESTTIMEOUT='600m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./azurerm/internal/services/kusto -run=TestAccKustoEventHubDataConnection_unbound -timeout 600m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
2021/03/10 09:45:41 [DEBUG] not using binary driver name, it's no longer needed
2021/03/10 09:45:41 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccKustoEventHubDataConnection_unboundMapping1
=== PAUSE TestAccKustoEventHubDataConnection_unboundMapping1
=== RUN   TestAccKustoEventHubDataConnection_unboundMapping2
=== PAUSE TestAccKustoEventHubDataConnection_unboundMapping2
=== CONT  TestAccKustoEventHubDataConnection_unboundMapping1
=== CONT  TestAccKustoEventHubDataConnection_unboundMapping2
--- PASS: TestAccKustoEventHubDataConnection_unboundMapping1 (1574.67s)
--- PASS: TestAccKustoEventHubDataConnection_unboundMapping2 (1747.31s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/kusto	1748.615s
```
@ghost ghost added the size/L label Mar 10, 2021
@katbyte katbyte added this to the v2.51.0 milestone Mar 10, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@katbyte katbyte merged commit 0429810 into hashicorp:master Mar 10, 2021
katbyte added a commit that referenced this pull request Mar 10, 2021
@ghost
Copy link

ghost commented Mar 12, 2021

This has been released in version 2.51.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.51.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 10, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_kusto_eventhub_data_connection requires too many arguments
2 participants