Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_function_app_host_keys - support for event_grid_extension_config_key #10823

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Mar 4, 2021

Fix #8385

Test Result

💤 make testacc TEST=./azurerm/internal/services/web TESTARGS='-run="TestAccFunctionAppHostKeysDataSource_basic"'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test ./azurerm/internal/services/web -v -run="TestAccFunctionAppHostKeysDataSource_basic" -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
2021/03/04 11:38:27 [DEBUG] not using binary driver name, it's no longer needed
2021/03/04 11:38:27 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccFunctionAppHostKeysDataSource_basic
=== PAUSE TestAccFunctionAppHostKeysDataSource_basic
=== CONT  TestAccFunctionAppHostKeysDataSource_basic
--- PASS: TestAccFunctionAppHostKeysDataSource_basic (296.49s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/web 296.618s

@magodo magodo added the service/functions Function Apps label Mar 4, 2021
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit 33929f8 into hashicorp:master Mar 4, 2021
@tombuildsstuff tombuildsstuff added this to the v2.50.0 milestone Mar 4, 2021
tombuildsstuff added a commit that referenced this pull request Mar 4, 2021
@ghost
Copy link

ghost commented Mar 5, 2021

This has been released in version 2.50.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.50.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 3, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend azurerm_function_app_host_keys with Event Grid system key
2 participants