Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencies: updating to v52.0.0 of github.com/Azure/azure-sdk-for-go #10787

Merged
merged 8 commits into from
Mar 3, 2021

Conversation

tombuildsstuff
Copy link
Contributor

This PR intentionally goes to v52.0.0 and not v52.1.0 of the Azure SDK for Go - to keep the diff smaller given the major changes in that release. This PR also switches out the dependency on github.com/satori/uuid for github.com/gofrs/uuid.

Reviewing this will likely be fun - so it's intentionally split up commit by commit.

@tombuildsstuff tombuildsstuff added this to the v2.50.0 milestone Mar 2, 2021
@ghost ghost added the size/XXL label Mar 2, 2021
@tombuildsstuff tombuildsstuff marked this pull request as draft March 2, 2021 10:16
@tombuildsstuff tombuildsstuff marked this pull request as ready for review March 2, 2021 10:36
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tombuildsstuff - LGTM 👍

@tombuildsstuff
Copy link
Contributor Author

Media tests pass:

Screenshot 2021-03-03 at 08 08 46

@tombuildsstuff tombuildsstuff merged commit 6bbf4dc into master Mar 3, 2021
@tombuildsstuff tombuildsstuff deleted the deps/azure-sdk-v52.0 branch March 3, 2021 07:13
tombuildsstuff added a commit that referenced this pull request Mar 3, 2021
@ghost
Copy link

ghost commented Mar 5, 2021

This has been released in version 2.50.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.50.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 2, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants