azurerm_kubernetes_cluster: support private_dns_zone_id with service_principal

[favoretti]

AKS supports private DNS zone ID not only with user managed identity,
but also with a service principal.

Fixes #10558

[favoretti]

2021/02/25 13:34:37 [DEBUG] not using binary driver name, it's no longer needed
2021/02/25 13:34:37 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccKubernetesCluster_privateClusterOnWithPrivateDNSZone
=== PAUSE TestAccKubernetesCluster_privateClusterOnWithPrivateDNSZone
=== CONT  TestAccKubernetesCluster_privateClusterOnWithPrivateDNSZone
--- PASS: TestAccKubernetesCluster_privateClusterOnWithPrivateDNSZone (819.98s)

$ TF_ACC=1 go test -v ./azurerm/internal/services/containers -timeout=1000m -run=TestAccKubernetesCluster_privateClusterOnWithPrivateDNSZoneAndServicePrincipal -run=TestAccKubernetesCluster_privateClusterOnWithPrivateDNSZoneSystem
2021/02/25 13:57:02 [DEBUG] not using binary driver name, it's no longer needed
2021/02/25 13:57:02 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccKubernetesCluster_privateClusterOnWithPrivateDNSZoneSystem
=== PAUSE TestAccKubernetesCluster_privateClusterOnWithPrivateDNSZoneSystem
=== CONT  TestAccKubernetesCluster_privateClusterOnWithPrivateDNSZoneSystem
--- PASS: TestAccKubernetesCluster_privateClusterOnWithPrivateDNSZoneSystem (785.89s)

$ TF_ACC=1 go test -v ./azurerm/internal/services/containers -timeout=1000m -run=TestAccKubernetesCluster_privateClusterOnWithPrivateDNSZoneAndServicePrincipal
2021/02/25 14:10:35 [DEBUG] not using binary driver name, it's no longer needed
2021/02/25 14:10:35 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccKubernetesCluster_privateClusterOnWithPrivateDNSZoneAndServicePrincipal
=== PAUSE TestAccKubernetesCluster_privateClusterOnWithPrivateDNSZoneAndServicePrincipal
=== CONT  TestAccKubernetesCluster_privateClusterOnWithPrivateDNSZoneAndServicePrincipal
--- PASS: TestAccKubernetesCluster_privateClusterOnWithPrivateDNSZoneAndServicePrincipal (783.55s)

[tombuildsstuff]

hey @favoretti

Thanks for this PR

Taking a look through here whilst on the whole this looks pretty good - support for Service Principals within AKS is deprecated and will be removed in the future, as such we should de-emphasis that if possible.

Thanks!

[favoretti]

@tombuildsstuff Understood. Done :)

[tombuildsstuff]

LGTM - thanks for pushing those changes @favoretti 👍

[tombuildsstuff]

Test passes:

[ghost]

This has been released in version 2.50.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.50.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!