Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse userAssignedIdentites insensitively #10722

Merged
merged 2 commits into from
Mar 1, 2021
Merged

Parse userAssignedIdentites insensitively #10722

merged 2 commits into from
Mar 1, 2021

Conversation

terricain
Copy link
Contributor

Parse userAssignedIdentities insensitively when dealing with Virtual Machines and VMSS.

Fixes #10300

Sometimes the Azure API returns userAssignedIdentities all lowercase in the resource ID.

@ghost ghost added the size/L label Feb 24, 2021
@tombuildsstuff tombuildsstuff added this to the v2.50.0 milestone Mar 1, 2021
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @terrycain

Thanks for this PR - aside from one minor comment (which I'll push a commit for) this otherwise LGTM 👍

Thanks!

azurerm/internal/tools/generator-resource-id/README.md Outdated Show resolved Hide resolved
@tombuildsstuff tombuildsstuff merged commit 666879e into hashicorp:master Mar 1, 2021
tombuildsstuff added a commit that referenced this pull request Mar 1, 2021
@terricain terricain deleted the fix_userAssignedIdentities branch March 1, 2021 11:59
@terricain
Copy link
Contributor Author

Awesome thanks @tombuildsstuff, don't suppose you know when the next release will be?

@ghost
Copy link

ghost commented Mar 5, 2021

This has been released in version 2.50.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.50.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 31, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

r/linux|windows_virtual_machine: should parse userAssignedIdentities insensitively to work around broken api
2 participants