new resource: azurerm_sentinel_data_connector_azure_security_center

[magodo]

new resource: azurerm_sentinel_data_connector_azure_security_center

[tombuildsstuff]

@magodo running the tests for this I get:

Error: creating Data Connector: (Name "accTestDC-210301102602516304" / Workspace Name "acctestLAW-210301102602516304" / Resource Group "acctestRG-sentinel-210301102602516304"): securityinsight.DataConnectorsClient#CreateOrUpdate: Failure responding to request: StatusCode=401 -- Original Error: autorest/azure: Service returned an error. Status=401 Code="InvalidLicense" Message="License is invalid"

Does this need a Security Center licence?

[magodo]

@tombuildsstuff Indeed. Below is the "proof" that test can pass:

💤 make testacc TEST=./azurerm/internal/services/sentinel TESTARGS='-run TestAccAzureRMSentinelDataConnectorAzureSecurityCenter_'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test ./azurerm/internal/services/sentinel -v -run TestAccAzureRMSentinelDataConnectorAzureSecurityCenter_ -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
2021/03/01 21:48:06 [DEBUG] not using binary driver name, it's no longer needed
2021/03/01 21:48:07 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccAzureRMSentinelDataConnectorAzureSecurityCenter_basic
=== PAUSE TestAccAzureRMSentinelDataConnectorAzureSecurityCenter_basic
=== RUN   TestAccAzureRMSentinelDataConnectorAzureSecurityCenter_complete
=== PAUSE TestAccAzureRMSentinelDataConnectorAzureSecurityCenter_complete
=== RUN   TestAccAzureRMSentinelDataConnectorAzureSecurityCenter_requiresImport
=== PAUSE TestAccAzureRMSentinelDataConnectorAzureSecurityCenter_requiresImport
=== CONT  TestAccAzureRMSentinelDataConnectorAzureSecurityCenter_requiresImport
=== CONT  TestAccAzureRMSentinelDataConnectorAzureSecurityCenter_complete
=== CONT  TestAccAzureRMSentinelDataConnectorAzureSecurityCenter_basic
--- PASS: TestAccAzureRMSentinelDataConnectorAzureSecurityCenter_basic (180.86s)
--- PASS: TestAccAzureRMSentinelDataConnectorAzureSecurityCenter_complete (184.45s)
--- PASS: TestAccAzureRMSentinelDataConnectorAzureSecurityCenter_requiresImport (193.58s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/sentinel    193.730s

[katbyte]

LGTM 👍

[ghost]

This has been released in version 2.51.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.51.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!