Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new resource: azurerm_sentinel_data_connector_azure_advanced_threat_protection' #10666

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Feb 20, 2021

new resource: azurerm_sentinel_data_connector_azure_advanced_threat_protection'

@magodo magodo force-pushed the sentinel_dataconnector_azure_advanced_threat_protection branch from 657a97c to e42547a Compare February 23, 2021 02:09
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @magodo

Thanks for this PR - I've taken a look through and left one comment inline but on the whole this looks pretty good, if we can fix up the comments then this should be otherwise good to go 👍

Thanks!

@manicminer manicminer force-pushed the sentinel_dataconnector_azure_advanced_threat_protection branch from 01dbedf to 3a948c9 Compare March 10, 2021 22:35
Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @magodo. I've added a note to the docs about the AAD license requirements as well as securityinsight.AATPDataConnector to the supported types in the import validation function.

Screenshot 2021-03-11 at 01 23 34

@manicminer manicminer added this to the v2.51.0 milestone Mar 11, 2021
@manicminer manicminer merged commit 3ef085e into hashicorp:master Mar 11, 2021
manicminer added a commit that referenced this pull request Mar 11, 2021
@ghost
Copy link

ghost commented Mar 12, 2021

This has been released in version 2.51.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.51.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 10, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants