Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_sql_database: changes to collation force a new resource #1066

Merged
merged 4 commits into from
Apr 9, 2018
Merged

azurerm_sql_database: changes to collation force a new resource #1066

merged 4 commits into from
Apr 9, 2018

Conversation

mbfrahry
Copy link
Member

@mbfrahry mbfrahry commented Apr 3, 2018

This PR builds off of #969 by adding a test to confirm that the fix works

=== RUN   TestAccAzureRMSqlDatabase_collation
--- PASS: TestAccAzureRMSqlDatabase_collation (240.22s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	240.244s

@mbfrahry mbfrahry mentioned this pull request Apr 3, 2018
Closed
3 tasks
@metacpp metacpp self-requested a review April 3, 2018 22:30
@tombuildsstuff tombuildsstuff added this to the 1.3.3 milestone Apr 4, 2018
@tombuildsstuff tombuildsstuff changed the title Vlouwagie sql collation fix azurerm_sql_database: changes to collation force a new resource Apr 9, 2018
tombuildsstuff
tombuildsstuff approved these changes Apr 9, 2018
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff
Copy link
Contributor

Ignoring a known test failure, the tests pass:

screen shot 2018-04-09 at 08 25 56

@tombuildsstuff tombuildsstuff merged commit 5439dfe into master Apr 9, 2018
@tombuildsstuff tombuildsstuff deleted the vlouwagie-sql-collation-fix branch April 9, 2018 06:31
tombuildsstuff added a commit that referenced this pull request Apr 9, 2018
@tombuildsstuff
Updating to include #1066
0e16b98
@katbyte katbyte mentioned this pull request Apr 17, 2018
Closed
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

@paultyng paultyng Awaiting requested review from paultyng

@metacpp metacpp Awaiting requested review from metacpp

Assignees
No one assigned
Labels
enhancement service/mssql Microsoft SQL Server
Projects
None yet
Milestone
v1.3.3
Development

Successfully merging this pull request may close these issues.
2 participants
@mbfrahry @tombuildsstuff