-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TemplateSpec Support for Template Deployments #10603
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @jackofallops
Thanks for this PR - on the whole this looks pretty good but I've left some comments inline - if we can fix those up then this should otherwise be good to go 👍
Thanks!
azurerm/internal/services/resource/management_group_template_deployment_resource.go
Show resolved
Hide resolved
azurerm/internal/services/resource/parse/management_group_template_deployment_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/resource/parse/tenant_template_deployment_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/resource/resource_group_template_deployment_resource.go
Show resolved
Hide resolved
azurerm/internal/services/resource/subscription_template_deployment_resource.go
Show resolved
Hide resolved
website/docs/r/management_group_template_deployment.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/management_group_template_deployment.html.markdown
Outdated
Show resolved
Hide resolved
azurerm/internal/services/resource/management_group_template_deployment_resource.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
LGTM 👍 |
This has been released in version 2.53.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.53.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
New Resource:
azurerm_management_group_template_deployment
New Resource:
azurerm_tenant_template_deployment
New Data Source:
azurerm_template_spec_version
azurerm_resource_group_template_deployment
- add support fortemplate_spec_version_id
propertyazurerm_subscription_template_deployment
- add support fortemplate_spec_version_id
propertyThis PR introduces support for deployments from the Template Spec preview by allowing the deployment resources to reference a published Template Spec Version ID, discoverable using the new data source.