azurerm_cosmosdb_mongo_collection: ignore throughput if Cosmos DB provisioned in 'serverless' capacity mode
#10389
Conversation
There was a problem hiding this comment.
Hey @wiebeck, thanks for taking the time to write this PR! I just have a minor comment for an extra anil check and a request to add serverless tests to each of the resources you've touched. I believe a couple already have tests for serverless so we just have to make sure the others have them too
| func isServerlessCapacityMode(accResp documentdb.DatabaseAccountGetResults) bool { | ||
| if props := accResp.DatabaseAccountGetProperties; props != nil && props.Capabilities != nil { | ||
| for _, v := range *props.Capabilities { | ||
| if *v.Name == "EnableServerless" { |
There was a problem hiding this comment.
We should confirm that v isn't nil before pointing to it
mbfrahry
changed the title
azurerm_cosmosdb_mongo_collection: ignore throughput if Cosmos DB provisioned in 'serverless' capacity mode
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
This should fix #9697. I stumbled upon the same "Error reading Throughput on Cosmos Mongo Collection" when I provisioned a "serverless" Cosmos DB in Mongo mode.
There was already some code in other places (obviously missing from
cosmosdb_mongo_collection_resource.go) that handles throughput if and only if...CapabilitiesCapabilitiesdo not containEnableServerlessHowever I think that throughput should also be handled if there are no
Capabilitiessince "Provisioned throughput" is the default, so I fixed that as well.I moved the code into a central function
isServerlessCapacityMode(DRY!) which I put into filecosmosdb_account_resource.go. Not sure if this is the right place though.Feedback very welcome!