-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resource: azurerm_cosmosdb_cassandra_table #10328
New resource: azurerm_cosmosdb_cassandra_table #10328
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @favoretti
Thanks for this PR - taking a look through on the whole this looks pretty good to me, my main question is whether it's worth parsing this information from a cassandra_keyspace_id
field, rather than taking 3 separate strings for this information - since the Keyspace is likely to be provisioned at the same time - WDYT?
Thanks!
azurerm/internal/services/cosmos/cosmosdb_cassandra_table_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/cosmos/cosmosdb_cassandra_table_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/cosmos/cosmosdb_cassandra_table_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/cosmos/cosmosdb_cassandra_table_resource.go
Outdated
Show resolved
Hide resolved
|
We were about to do it with |
@djsly 2.45 has been cut, so the best chance is it'll be in 2.46, which is next week. If I were to guess - this is good to merge. |
Thansk a lot. I'll have high hope for the next release then ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @favoretti
Thanks for pushing those changes - apologies for the delayed re-review here!
Taking a look through this mostly LGTM - however I believe we can also remove the resource_group_name
field since this can be inferred from the Table ID, WDYT?
Thanks!
azurerm/internal/services/cosmos/cosmosdb_cassandra_table_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/cosmos/cosmosdb_cassandra_table_resource.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for pushing those changes @favoretti
Co-authored-by: Tom Harvey <[email protected]>
Co-authored-by: Tom Harvey <[email protected]>
…urce.go Co-authored-by: Tom Harvey <[email protected]>
…urce.go Co-authored-by: Tom Harvey <[email protected]>
…urce.go Co-authored-by: Tom Harvey <[email protected]>
…urce.go Co-authored-by: Tom Harvey <[email protected]>
…urce.go Co-authored-by: Tom Harvey <[email protected]>
…urce.go Co-authored-by: Tom Harvey <[email protected]>
…urce.go Co-authored-by: Tom Harvey <[email protected]>
…urce.go Co-authored-by: Tom Harvey <[email protected]>
…urce.go Co-authored-by: Tom Harvey <[email protected]>
…urce.go Co-authored-by: Tom Harvey <[email protected]>
…urce.go Co-authored-by: Tom Harvey <[email protected]>
…urce.go Co-authored-by: Tom Harvey <[email protected]>
…urce.go Co-authored-by: Tom Harvey <[email protected]>
|
This has been released in version 2.46.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.46.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Fixes #10327