Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_kusto_cluster - supports double_encryption_enabled, systemAssignedIdentity and systemAssignedUserAssignedIdentity #10264

Merged
merged 2 commits into from
Mar 1, 2021

Conversation

njuCZ
Copy link
Contributor

@njuCZ njuCZ commented Jan 21, 2021

support new fields: "double_encryption_enabled"
enhancement for identity block: support systemAssignedIdentity and systemAssignedUserAssignedIdentity
once more validation item for sku name

the acctest "TestAccKustoCluster_zones" failed either in master branch, I have emailed the service team

acording to https://docs.microsoft.com/en-us/azure/data-explorer/double-encryption?tabs=portal

Enabling double encryption is only possible during cluster creation.
Once infrastructure encryption is enabled on your cluster, you can't disable it.

We could infer that it's a forcenew field

…ignedIdentity and systemAssignedUserAssignedIdentity
@njuCZ njuCZ closed this Jan 22, 2021
@njuCZ njuCZ reopened this Jan 22, 2021
@njuCZ
Copy link
Contributor Author

njuCZ commented Jan 22, 2021

the website-test CI has been removed. It seems reopen the PR could not trigger the CI

@njuCZ njuCZ closed this Feb 3, 2021
@njuCZ njuCZ reopened this Feb 3, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @njuCZ - LGTM 👍

azurerm/internal/services/kusto/identity.go Show resolved Hide resolved
@katbyte katbyte merged commit bbe21d8 into hashicorp:master Mar 1, 2021
katbyte added a commit that referenced this pull request Mar 1, 2021
@ghost
Copy link

ghost commented Mar 5, 2021

This has been released in version 2.50.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.50.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 31, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants