-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resource: azurerm_api_management_identity_provider_aadb2c #10240
Conversation
Since I just finished creating generators for all APIM resources, would you also mind adding one here? :) |
6b333ab
to
f5b9b3b
Compare
@manicminer would you mind rebasing this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @manicminer
Thanks for this PR - I've taken a look through and left some comments inline but if we can fix those up (and rebase this) then this otherwise LGTM 👍
Thanks!
azurerm/internal/services/apimanagement/api_management_identity_provider_aadb2c_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/apimanagement/api_management_identity_provider_aadb2c_resource.go
Outdated
Show resolved
Hide resolved
...erm/internal/services/apimanagement/api_management_identity_provider_aadb2c_resource_test.go
Outdated
Show resolved
Hide resolved
website/docs/r/api_management_identity_provider_aadb2c.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/api_management_identity_provider_aadb2c.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/api_management_identity_provider_aadb2c.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/api_management_identity_provider_aadb2c.html.markdown
Outdated
Show resolved
Hide resolved
f5b9b3b
to
0468a72
Compare
Thanks for the review! I've fixed it up per the suggestions. Test results pending. |
5bd2691
to
216395c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
…reating/updating, use API URL exported from parent resource, fix up documentation
216395c
to
6ba4c83
Compare
This has been released in version 2.46.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.46.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Add new resource
azurerm_api_management_identity_provider_aadb2c
.This is tricky to test because creation requires a preexisting B2C tenant with matching policies already configured, plus an application registration in that tenant with sufficient privileges to create another application configured for the APIM instance.
I've set one up by hand (it's the only way at present) and confirmed it works locally. Any B2C tenant can be used, using the basic configuration described at https://docs.microsoft.com/en-us/azure/api-management/api-management-howto-aad-b2c
Accordingly, the acctests rely on additional environment variables to be set (and be valid). The tests are skipped if these are not set.
Very much open to suggestions if there's a better way to inject/detect/consume these!
ARM_TEST_B2C_TENANT_ID
ARM_TEST_B2C_TENANT_SLUG
ARM_TEST_B2C_CLIENT_ID
ARM_TEST_B2C_CLIENT_SECRET
Test results
Replaces: #7785