Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider/aws: Add ARN as an exported param for aws_ecs_cluster #991

Merged
merged 1 commit into from
Jun 28, 2017
Merged

provider/aws: Add ARN as an exported param for aws_ecs_cluster #991

merged 1 commit into from
Jun 28, 2017

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Jun 28, 2017

Fixes: #988

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSEcsDataSource'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSEcsDataSource -timeout 120m
=== RUN   TestAccAWSEcsDataSource_ecsCluster
--- PASS: TestAccAWSEcsDataSource_ecsCluster (116.89s)
=== RUN   TestAccAWSEcsDataSource_ecsContainerDefinition
--- PASS: TestAccAWSEcsDataSource_ecsContainerDefinition (116.93s)
=== RUN   TestAccAWSEcsDataSource_ecsTaskDefinition
--- PASS: TestAccAWSEcsDataSource_ecsTaskDefinition (30.72s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	264.579s

@stack72
provider/aws: Add ARN as an exported param for aws_ecs_cluster
fdcf71c 
Fixes: #988

```
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSEcsDataSource'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSEcsDataSource -timeout 120m
=== RUN   TestAccAWSEcsDataSource_ecsCluster
--- PASS: TestAccAWSEcsDataSource_ecsCluster (116.89s)
=== RUN   TestAccAWSEcsDataSource_ecsContainerDefinition
--- PASS: TestAccAWSEcsDataSource_ecsContainerDefinition (116.93s)
=== RUN   TestAccAWSEcsDataSource_ecsTaskDefinition
--- PASS: TestAccAWSEcsDataSource_ecsTaskDefinition (30.72s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	264.579s
```
@stack72 stack72 added the bug Addresses a defect in current functionality. label Jun 28, 2017
grubernaut
grubernaut approved these changes Jun 28, 2017
View reviewed changes
Copy link
Contributor

@grubernaut grubernaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stack72 stack72 merged commit 5ad5228 into master Jun 28, 2017
@stack72 stack72 deleted the b-aws-ecs-ds-988 branch June 28, 2017 21:09
@ghost
Copy link

ghost commented Apr 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@grubernaut grubernaut grubernaut approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect documentation for datasource aws_ecs_cluster
2 participants
@stack72 @grubernaut