Final retries for routes

[ryndaniels]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #7873

Release note for CHANGELOG:

BUG FIXES:
* resource/aws_route: Final retry after timeout creating route
* resource/aws_route_table: Final retry after timeout updating route table
* resource/aws_route_table_association: Final retry after timeout creating route table association

Output from acceptance testing:

$  make testacc TESTARGS="-run=TestAccAWSRoute_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSRoute_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSRoute_basic
=== PAUSE TestAccAWSRoute_basic
=== RUN   TestAccAWSRoute_ipv6Support
=== PAUSE TestAccAWSRoute_ipv6Support
=== RUN   TestAccAWSRoute_ipv6ToInternetGateway
=== PAUSE TestAccAWSRoute_ipv6ToInternetGateway
=== RUN   TestAccAWSRoute_ipv6ToInstance
=== PAUSE TestAccAWSRoute_ipv6ToInstance
=== RUN   TestAccAWSRoute_ipv6ToNetworkInterface
=== PAUSE TestAccAWSRoute_ipv6ToNetworkInterface
=== RUN   TestAccAWSRoute_ipv6ToPeeringConnection
=== PAUSE TestAccAWSRoute_ipv6ToPeeringConnection
=== RUN   TestAccAWSRoute_changeRouteTable
=== PAUSE TestAccAWSRoute_changeRouteTable
=== RUN   TestAccAWSRoute_changeCidr
=== PAUSE TestAccAWSRoute_changeCidr
=== RUN   TestAccAWSRoute_noopdiff
=== PAUSE TestAccAWSRoute_noopdiff
=== RUN   TestAccAWSRoute_doesNotCrashWithVPCEndpoint
=== PAUSE TestAccAWSRoute_doesNotCrashWithVPCEndpoint
=== RUN   TestAccAWSRoute_TransitGatewayID_DestinationCidrBlock
=== PAUSE TestAccAWSRoute_TransitGatewayID_DestinationCidrBlock
=== CONT  TestAccAWSRoute_basic
=== CONT  TestAccAWSRoute_TransitGatewayID_DestinationCidrBlock
=== CONT  TestAccAWSRoute_ipv6ToNetworkInterface
=== CONT  TestAccAWSRoute_ipv6ToInternetGateway
=== CONT  TestAccAWSRoute_noopdiff
=== CONT  TestAccAWSRoute_doesNotCrashWithVPCEndpoint
=== CONT  TestAccAWSRoute_changeRouteTable
=== CONT  TestAccAWSRoute_changeCidr
=== CONT  TestAccAWSRoute_ipv6ToInstance
=== CONT  TestAccAWSRoute_ipv6Support
=== CONT  TestAccAWSRoute_ipv6ToPeeringConnection
--- PASS: TestAccAWSRoute_ipv6Support (62.39s)
--- PASS: TestAccAWSRoute_ipv6ToPeeringConnection (66.22s)
--- PASS: TestAccAWSRoute_basic (73.64s)
--- PASS: TestAccAWSRoute_ipv6ToInternetGateway (76.03s)
--- PASS: TestAccAWSRoute_doesNotCrashWithVPCEndpoint (83.95s)
--- PASS: TestAccAWSRoute_changeCidr (121.21s)
--- PASS: TestAccAWSRoute_changeRouteTable (122.83s)
--- PASS: TestAccAWSRoute_ipv6ToInstance (159.76s)
--- PASS: TestAccAWSRoute_noopdiff (176.14s)
--- PASS: TestAccAWSRoute_ipv6ToNetworkInterface (199.13s)
--- PASS: TestAccAWSRoute_TransitGatewayID_DestinationCidrBlock (324.05s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       324.937s

make testacc TESTARGS="-run=TestAccAWSRouteTable_"     
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSRouteTable_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSRouteTable_basic
=== PAUSE TestAccAWSRouteTable_basic
=== RUN   TestAccAWSRouteTable_instance
=== PAUSE TestAccAWSRouteTable_instance
=== RUN   TestAccAWSRouteTable_ipv6
=== PAUSE TestAccAWSRouteTable_ipv6
=== RUN   TestAccAWSRouteTable_tags
=== PAUSE TestAccAWSRouteTable_tags
=== RUN   TestAccAWSRouteTable_panicEmptyRoute
=== PAUSE TestAccAWSRouteTable_panicEmptyRoute
=== RUN   TestAccAWSRouteTable_Route_ConfigMode
=== PAUSE TestAccAWSRouteTable_Route_ConfigMode
=== RUN   TestAccAWSRouteTable_Route_TransitGatewayID
=== PAUSE TestAccAWSRouteTable_Route_TransitGatewayID
=== RUN   TestAccAWSRouteTable_vpcPeering
=== PAUSE TestAccAWSRouteTable_vpcPeering
=== RUN   TestAccAWSRouteTable_vgwRoutePropagation
=== PAUSE TestAccAWSRouteTable_vgwRoutePropagation
=== CONT  TestAccAWSRouteTable_basic
=== CONT  TestAccAWSRouteTable_Route_ConfigMode
=== CONT  TestAccAWSRouteTable_instance
=== CONT  TestAccAWSRouteTable_vpcPeering
=== CONT  TestAccAWSRouteTable_panicEmptyRoute
=== CONT  TestAccAWSRouteTable_tags
=== CONT  TestAccAWSRouteTable_ipv6
=== CONT  TestAccAWSRouteTable_vgwRoutePropagation
=== CONT  TestAccAWSRouteTable_Route_TransitGatewayID
--- PASS: TestAccAWSRouteTable_panicEmptyRoute (37.07s)
--- PASS: TestAccAWSRouteTable_ipv6 (61.95s)
--- PASS: TestAccAWSRouteTable_vpcPeering (71.78s)
--- PASS: TestAccAWSRouteTable_vgwRoutePropagation (75.86s)
--- PASS: TestAccAWSRouteTable_tags (87.73s)
--- PASS: TestAccAWSRouteTable_basic (109.71s)
--- PASS: TestAccAWSRouteTable_Route_ConfigMode (140.21s)
--- PASS: TestAccAWSRouteTable_instance (176.45s)
--- PASS: TestAccAWSRouteTable_Route_TransitGatewayID (367.48s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       368.599s

make testacc TESTARGS="-run=TestAccAWSRouteTableAssociation"      
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSRouteTableAssociation -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSRouteTableAssociation_basic
=== PAUSE TestAccAWSRouteTableAssociation_basic
=== RUN   TestAccAWSRouteTableAssociation_replace
=== PAUSE TestAccAWSRouteTableAssociation_replace
=== CONT  TestAccAWSRouteTableAssociation_basic
=== CONT  TestAccAWSRouteTableAssociation_replace
--- PASS: TestAccAWSRouteTableAssociation_replace (116.95s)
--- PASS: TestAccAWSRouteTableAssociation_basic (119.09s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       120.225s

[bflad]

LGTM 🚀

--- PASS: TestAccAWSRoute_basic (29.08s)
--- PASS: TestAccAWSRoute_changeCidr (45.68s)
--- PASS: TestAccAWSRoute_changeRouteTable (38.95s)
--- PASS: TestAccAWSRoute_doesNotCrashWithVPCEndpoint (31.66s)
--- PASS: TestAccAWSRoute_ipv6Support (25.68s)
--- PASS: TestAccAWSRoute_ipv6ToInstance (97.15s)
--- PASS: TestAccAWSRoute_ipv6ToInternetGateway (35.04s)
--- PASS: TestAccAWSRoute_ipv6ToNetworkInterface (139.39s)
--- PASS: TestAccAWSRoute_ipv6ToPeeringConnection (29.88s)
--- PASS: TestAccAWSRoute_noopdiff (185.32s)
--- PASS: TestAccAWSRoute_TransitGatewayID_DestinationCidrBlock (289.33s)
--- PASS: TestAccAWSRouteTable_basic (26.94s)
--- PASS: TestAccAWSRouteTable_instance (129.98s)
--- PASS: TestAccAWSRouteTable_ipv6 (10.84s)
--- PASS: TestAccAWSRouteTable_panicEmptyRoute (6.64s)
--- PASS: TestAccAWSRouteTable_Route_ConfigMode (45.24s)
--- PASS: TestAccAWSRouteTable_Route_TransitGatewayID (320.29s)
--- PASS: TestAccAWSRouteTable_tags (22.47s)
--- PASS: TestAccAWSRouteTable_vgwRoutePropagation (39.76s)
--- PASS: TestAccAWSRouteTable_vpcPeering (25.02s)
--- PASS: TestAccAWSRouteTableAssociation_basic (27.76s)
--- PASS: TestAccAWSRouteTableAssociation_replace (27.42s)

[ghost]

This has been released in version 2.25.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!