Final retries for msk cluster

[ryndaniels]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #7873

Release note for CHANGELOG:

BUG FIXES:
* resource/aws_msk_cluster: Final retries after timeouts creating and deleting clusters

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSMskCluster"==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSMskCluster -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSMskClusterDataSource_Name
=== PAUSE TestAccAWSMskClusterDataSource_Name
=== RUN   TestAccAWSMskCluster_basic
=== PAUSE TestAccAWSMskCluster_basic
=== RUN   TestAccAWSMskCluster_BrokerNodeGroupInfo_EbsVolumeSize
=== PAUSE TestAccAWSMskCluster_BrokerNodeGroupInfo_EbsVolumeSize
=== RUN   TestAccAWSMskCluster_ClientAuthentication_Tls_CertificateAuthorityArns
--- SKIP: TestAccAWSMskCluster_ClientAuthentication_Tls_CertificateAuthorityArns (0.00s)
    resource_aws_msk_cluster_test.go:155: Requires the aws_acmpca_certificate_authority resource to support importing the root CA certificate
=== RUN   TestAccAWSMskCluster_ConfigurationInfo_Revision
--- SKIP: TestAccAWSMskCluster_ConfigurationInfo_Revision (0.00s)
    resource_aws_msk_cluster_test.go:189: aws_msk_cluster is correctly calling UpdateClusterConfiguration however API is always returning 429 and 500 errors
=== RUN   TestAccAWSMskCluster_EncryptionInfo_EncryptionAtRestKmsKeyArn
=== PAUSE TestAccAWSMskCluster_EncryptionInfo_EncryptionAtRestKmsKeyArn
=== RUN   TestAccAWSMskCluster_EncryptionInfo_EncryptionInTransit_ClientBroker
=== PAUSE TestAccAWSMskCluster_EncryptionInfo_EncryptionInTransit_ClientBroker
=== RUN   TestAccAWSMskCluster_EncryptionInfo_EncryptionInTransit_InCluster
=== PAUSE TestAccAWSMskCluster_EncryptionInfo_EncryptionInTransit_InCluster
=== RUN   TestAccAWSMskCluster_EnhancedMonitoring
=== PAUSE TestAccAWSMskCluster_EnhancedMonitoring
=== RUN   TestAccAWSMskCluster_NumberOfBrokerNodes
=== PAUSE TestAccAWSMskCluster_NumberOfBrokerNodes
=== RUN   TestAccAWSMskCluster_Tags
=== PAUSE TestAccAWSMskCluster_Tags
=== CONT  TestAccAWSMskClusterDataSource_Name
=== CONT  TestAccAWSMskCluster_EncryptionInfo_EncryptionInTransit_ClientBroker
=== CONT  TestAccAWSMskCluster_basic
=== CONT  TestAccAWSMskCluster_EncryptionInfo_EncryptionInTransit_InCluster
=== CONT  TestAccAWSMskCluster_NumberOfBrokerNodes
=== CONT  TestAccAWSMskCluster_EnhancedMonitoring
=== CONT  TestAccAWSMskCluster_BrokerNodeGroupInfo_EbsVolumeSize
=== CONT  TestAccAWSMskCluster_Tags
=== CONT  TestAccAWSMskCluster_EncryptionInfo_EncryptionAtRestKmsKeyArn
--- PASS: TestAccAWSMskCluster_EncryptionInfo_EncryptionInTransit_InCluster (771.22s)
--- FAIL: TestAccAWSMskCluster_Tags (845.03s)
    testing.go:568: Step 0 error: After applying this step, the plan was not empty:
        
        DIFF:
        
...    
        
        STATE:
...
--- FAIL: TestAccAWSMskCluster_BrokerNodeGroupInfo_EbsVolumeSize (880.78s)
    testing.go:568: Step 0 error: After applying this step, the plan was not empty:
        
        DIFF:
        
...   
        
        STATE:
        
...
--- PASS: TestAccAWSMskCluster_EncryptionInfo_EncryptionInTransit_ClientBroker (887.45s)
--- FAIL: TestAccAWSMskCluster_NumberOfBrokerNodes (889.94s)
    testing.go:568: Step 0 error: Check failed: Check 2/9 error: aws_msk_cluster.test: Attribute 'bootstrap_brokers' didn't match "^(([-\\w]+\\.){1,}[\\w]+:\\d+,){2,}([-\\w]+\\.){1,}[\\w]+:\\d+$", got ""
--- FAIL: TestAccAWSMskCluster_EncryptionInfo_EncryptionAtRestKmsKeyArn (923.87s)
    testing.go:568: Step 0 error: After applying this step, the plan was not empty:
        
        DIFF:
        
...
        
        STATE:
        
...
--- FAIL: TestAccAWSMskCluster_basic (954.09s)
    testing.go:568: Step 0 error: Check failed: Check 3/27 error: aws_msk_cluster.test: Attribute 'bootstrap_brokers' didn't match "^(([-\\w]+\\.){1,}[\\w]+:\\d+,){2,}([-\\w]+\\.){1,}[\\w]+:\\d+$", got ""
--- FAIL: TestAccAWSMskClusterDataSource_Name (1000.95s)
    testing.go:568: Step 0 error: Check failed: Check 2/8 error: data.aws_msk_cluster.test: Attribute 'bootstrap_brokers' expected to be set
--- FAIL: TestAccAWSMskCluster_EnhancedMonitoring (1005.55s)
    testing.go:568: Step 0 error: After applying this step, the plan was not empty:
        
        DIFF:
        
... 
        
        STATE:
        
...
FAIL
FAIL    github.com/terraform-providers/terraform-provider-aws/aws       1006.420s
make: *** [testacc] Error 1

[bflad]

One thing, otherwise LGTM 🚀

I left notes about the testing in our acceptance testing commentary documentation.

[ghost]

This has been released in version 2.25.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!