Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add glue.trigger.workflow_name #9762

Merged
merged 2 commits into from
Nov 19, 2019
Merged

Add glue.trigger.workflow_name #9762

merged 2 commits into from
Nov 19, 2019

Conversation

Achal-Aggarwal
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@Achal-Aggarwal Achal-Aggarwal requested a review from a team August 14, 2019 05:23
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/glue Issues and PRs that pertain to the glue service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 14, 2019
@Achal-Aggarwal Achal-Aggarwal force-pushed the glue_trigger_workflow_name branch from 8d4a878 to 5365c68 Compare August 14, 2019 06:33
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 8, 2019
bflad
bflad suggested changes Nov 8, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Achal-Aggarwal 👋 Thanks for submitting this. One little thing to add the documentation for this new argument and then we can get this in. 👍

aws/resource_aws_glue_trigger.go
@@ -126,6 +126,11 @@ func resourceAwsGlueTrigger() *schema.Resource {
glue.TriggerTypeScheduled,
}, false),
},
"workflow_name": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add documentation for this new argument? Thanks! website/docs/r/glue_trigger.html.markdown

@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Nov 8, 2019
@bflad bflad self-assigned this Nov 9, 2019
@bflad bflad mentioned this pull request Nov 19, 2019
Merged
@bflad bflad added this to the v2.39.0 milestone Nov 19, 2019
@bflad
Copy link
Contributor

bflad commented Nov 19, 2019

Pulling in #9762, #10190, and #10891 while addressing any remaining feedback.

@bflad bflad mentioned this pull request Nov 19, 2019
Merged
bflad added a commit that referenced this pull request Nov 19, 2019
@bflad
resource/aws_glue_trigger: Updates to address #9762, #10190, and #10891…
4d2b505 
… complex merge and review feedback

Reference: #9762
Reference: #10190
Reference: #10891

Output from acceptance testing:

```
--- PASS: TestAccAWSGlueTrigger_WorkflowName (30.76s)
--- PASS: TestAccAWSGlueTrigger_Basic (50.13s)
--- PASS: TestAccAWSGlueTrigger_Description (54.13s)
--- PASS: TestAccAWSGlueTrigger_Predicate (65.53s)
--- PASS: TestAccAWSGlueTrigger_Schedule (79.04s)
--- PASS: TestAccAWSGlueTrigger_Crawler (85.59s)
--- PASS: TestAccAWSGlueTrigger_Enabled (117.36s)
```
@bflad bflad merged commit 5365c68 into hashicorp:master Nov 19, 2019
bflad added a commit that referenced this pull request Nov 19, 2019
@bflad
Update CHANGELOG for #9762, #10190, and #10891
162c526
@ghost
Copy link

ghost commented Nov 21, 2019

This has been released in version 2.39.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Nov 21, 2019
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad requested changes

Assignees

@bflad bflad

Labels
enhancement Requests to existing resources that expand the functionality or scope. service/glue Issues and PRs that pertain to the glue service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.39.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Achal-Aggarwal @bflad