Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final retries after timeouts in various code-related resources #9682

Merged
merged 1 commit into from
Aug 9, 2019
Merged

Final retries after timeouts in various code-related resources #9682

merged 1 commit into from
Aug 9, 2019

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #7873

Release note for CHANGELOG:

BUG FIXES
* resource/aws_codebuild_project: Final retries after timeouts creating and updating codebuild projects 
* resource/aws_codedeploy_deployment_group: Final retries after timeouts creating and updating deployment groups
* resource/aws_codepipeline: Final retry after timeout creating codepipeline

Output from acceptance testing:

NOTE the CodeBuildProject failure is not new


$ make testacc TESTARGS="-run=TestAccAWSCodeBuildProject"            
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSCodeBuildProject -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSCodeBuildProject_importBasic
=== PAUSE TestAccAWSCodeBuildProject_importBasic
=== RUN   TestAccAWSCodeBuildProject_basic
=== PAUSE TestAccAWSCodeBuildProject_basic
=== RUN   TestAccAWSCodeBuildProject_BadgeEnabled
=== PAUSE TestAccAWSCodeBuildProject_BadgeEnabled
=== RUN   TestAccAWSCodeBuildProject_BuildTimeout
=== PAUSE TestAccAWSCodeBuildProject_BuildTimeout
=== RUN   TestAccAWSCodeBuildProject_Cache
=== PAUSE TestAccAWSCodeBuildProject_Cache
=== RUN   TestAccAWSCodeBuildProject_Description
=== PAUSE TestAccAWSCodeBuildProject_Description
=== RUN   TestAccAWSCodeBuildProject_EncryptionKey
=== PAUSE TestAccAWSCodeBuildProject_EncryptionKey
=== RUN   TestAccAWSCodeBuildProject_Environment_EnvironmentVariable
=== PAUSE TestAccAWSCodeBuildProject_Environment_EnvironmentVariable
=== RUN   TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Type
=== PAUSE TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Type
=== RUN   TestAccAWSCodeBuildProject_Environment_Certificate
=== PAUSE TestAccAWSCodeBuildProject_Environment_Certificate
=== RUN   TestAccAWSCodeBuildProject_LogsConfig_CloudWatchLogs
=== PAUSE TestAccAWSCodeBuildProject_LogsConfig_CloudWatchLogs
=== RUN   TestAccAWSCodeBuildProject_LogsConfig_S3Logs
=== PAUSE TestAccAWSCodeBuildProject_LogsConfig_S3Logs
=== RUN   TestAccAWSCodeBuildProject_Source_Auth
=== PAUSE TestAccAWSCodeBuildProject_Source_Auth
=== RUN   TestAccAWSCodeBuildProject_Source_GitCloneDepth
=== PAUSE TestAccAWSCodeBuildProject_Source_GitCloneDepth
=== RUN   TestAccAWSCodeBuildProject_Source_InsecureSSL
=== PAUSE TestAccAWSCodeBuildProject_Source_InsecureSSL
=== RUN   TestAccAWSCodeBuildProject_Source_ReportBuildStatus_Bitbucket
=== PAUSE TestAccAWSCodeBuildProject_Source_ReportBuildStatus_Bitbucket
=== RUN   TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHub
=== PAUSE TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHub
=== RUN   TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHubEnterprise
=== PAUSE TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHubEnterprise
=== RUN   TestAccAWSCodeBuildProject_Source_Type_Bitbucket
=== PAUSE TestAccAWSCodeBuildProject_Source_Type_Bitbucket
=== RUN   TestAccAWSCodeBuildProject_Source_Type_CodeCommit
=== PAUSE TestAccAWSCodeBuildProject_Source_Type_CodeCommit
=== RUN   TestAccAWSCodeBuildProject_Source_Type_CodePipeline
=== PAUSE TestAccAWSCodeBuildProject_Source_Type_CodePipeline
=== RUN   TestAccAWSCodeBuildProject_Source_Type_GitHubEnterprise
=== PAUSE TestAccAWSCodeBuildProject_Source_Type_GitHubEnterprise
=== RUN   TestAccAWSCodeBuildProject_Source_Type_S3
=== PAUSE TestAccAWSCodeBuildProject_Source_Type_S3
=== RUN   TestAccAWSCodeBuildProject_Source_Type_NoSource
=== PAUSE TestAccAWSCodeBuildProject_Source_Type_NoSource
=== RUN   TestAccAWSCodeBuildProject_Source_Type_NoSourceInvalid
=== PAUSE TestAccAWSCodeBuildProject_Source_Type_NoSourceInvalid
=== RUN   TestAccAWSCodeBuildProject_Tags
=== PAUSE TestAccAWSCodeBuildProject_Tags
=== RUN   TestAccAWSCodeBuildProject_VpcConfig
=== PAUSE TestAccAWSCodeBuildProject_VpcConfig
=== RUN   TestAccAWSCodeBuildProject_WindowsContainer
=== PAUSE TestAccAWSCodeBuildProject_WindowsContainer
=== RUN   TestAccAWSCodeBuildProject_Artifacts_EncryptionDisabled
=== PAUSE TestAccAWSCodeBuildProject_Artifacts_EncryptionDisabled
=== RUN   TestAccAWSCodeBuildProject_Artifacts_NamespaceType
=== PAUSE TestAccAWSCodeBuildProject_Artifacts_NamespaceType
=== RUN   TestAccAWSCodeBuildProject_Artifacts_OverrideArtifactName
=== PAUSE TestAccAWSCodeBuildProject_Artifacts_OverrideArtifactName
=== RUN   TestAccAWSCodeBuildProject_Artifacts_Packaging
=== PAUSE TestAccAWSCodeBuildProject_Artifacts_Packaging
=== RUN   TestAccAWSCodeBuildProject_Artifacts_Path
=== PAUSE TestAccAWSCodeBuildProject_Artifacts_Path
=== RUN   TestAccAWSCodeBuildProject_SecondaryArtifacts
=== PAUSE TestAccAWSCodeBuildProject_SecondaryArtifacts
=== RUN   TestAccAWSCodeBuildProject_SecondarySources_CodeCommit
=== PAUSE TestAccAWSCodeBuildProject_SecondarySources_CodeCommit
=== RUN   TestAccAWSCodeBuildProject_Environment_RegistryCredential
=== PAUSE TestAccAWSCodeBuildProject_Environment_RegistryCredential
=== CONT  TestAccAWSCodeBuildProject_importBasic
=== CONT  TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHubEnterprise
=== CONT  TestAccAWSCodeBuildProject_Source_Type_Bitbucket
=== CONT  TestAccAWSCodeBuildProject_Environment_RegistryCredential
=== CONT  TestAccAWSCodeBuildProject_SecondarySources_CodeCommit
=== CONT  TestAccAWSCodeBuildProject_SecondaryArtifacts
=== CONT  TestAccAWSCodeBuildProject_Artifacts_Path
=== CONT  TestAccAWSCodeBuildProject_Source_Type_NoSourceInvalid
=== CONT  TestAccAWSCodeBuildProject_Source_Type_NoSource
=== CONT  TestAccAWSCodeBuildProject_Source_Type_S3
=== CONT  TestAccAWSCodeBuildProject_Source_Type_GitHubEnterprise
=== CONT  TestAccAWSCodeBuildProject_Source_Type_CodePipeline
=== CONT  TestAccAWSCodeBuildProject_Tags
=== CONT  TestAccAWSCodeBuildProject_Artifacts_Packaging
=== CONT  TestAccAWSCodeBuildProject_Artifacts_OverrideArtifactName
=== CONT  TestAccAWSCodeBuildProject_Artifacts_NamespaceType
=== CONT  TestAccAWSCodeBuildProject_Artifacts_EncryptionDisabled
=== CONT  TestAccAWSCodeBuildProject_WindowsContainer
=== CONT  TestAccAWSCodeBuildProject_Source_Type_CodeCommit
=== CONT  TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHub
--- PASS: TestAccAWSCodeBuildProject_Source_Type_NoSourceInvalid (25.04s)
=== CONT  TestAccAWSCodeBuildProject_VpcConfig
--- PASS: TestAccAWSCodeBuildProject_WindowsContainer (40.05s)
=== CONT  TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Type
--- PASS: TestAccAWSCodeBuildProject_Source_Type_GitHubEnterprise (40.11s)
=== CONT  TestAccAWSCodeBuildProject_Source_ReportBuildStatus_Bitbucket
--- PASS: TestAccAWSCodeBuildProject_Source_Type_CodePipeline (40.14s)
=== CONT  TestAccAWSCodeBuildProject_Cache
--- PASS: TestAccAWSCodeBuildProject_Source_Type_Bitbucket (40.27s)
=== CONT  TestAccAWSCodeBuildProject_Source_InsecureSSL
--- PASS: TestAccAWSCodeBuildProject_SecondarySources_CodeCommit (40.32s)
=== CONT  TestAccAWSCodeBuildProject_Environment_EnvironmentVariable
--- PASS: TestAccAWSCodeBuildProject_Source_Type_CodeCommit (40.33s)
=== CONT  TestAccAWSCodeBuildProject_Source_GitCloneDepth
--- PASS: TestAccAWSCodeBuildProject_Source_Type_NoSource (48.58s)
=== CONT  TestAccAWSCodeBuildProject_EncryptionKey
--- PASS: TestAccAWSCodeBuildProject_importBasic (50.89s)
=== CONT  TestAccAWSCodeBuildProject_Source_Auth
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHub (59.52s)
=== CONT  TestAccAWSCodeBuildProject_Description
--- PASS: TestAccAWSCodeBuildProject_Tags (59.57s)
=== CONT  TestAccAWSCodeBuildProject_LogsConfig_S3Logs
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts (67.38s)
=== CONT  TestAccAWSCodeBuildProject_basic
--- FAIL: TestAccAWSCodeBuildProject_Source_Auth (16.53s)
    testing.go:568: Step 1 error: errors during apply:
        
        Error: Error creating CodeBuild project: InvalidInputException: No Access token found, please visit AWS CodeBuild console to connect to GitHub
                status code: 400, request id: f6bb14e3-6c1a-4514-a83f-3c5a5ad2428e
        
          on /var/folders/pd/swwl85ks1nvbfy2pht84q2m40000gq/T/tf-test832210471/main.tf line 64:
          (source code not available)
        
        
=== CONT  TestAccAWSCodeBuildProject_LogsConfig_CloudWatchLogs
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHubEnterprise (68.21s)
=== CONT  TestAccAWSCodeBuildProject_Environment_Certificate
--- PASS: TestAccAWSCodeBuildProject_Source_Type_S3 (70.70s)
=== CONT  TestAccAWSCodeBuildProject_BuildTimeout
--- PASS: TestAccAWSCodeBuildProject_Environment_RegistryCredential (76.01s)
=== CONT  TestAccAWSCodeBuildProject_BadgeEnabled
--- PASS: TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Type (55.93s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_EncryptionDisabled (99.00s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Path (100.36s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_OverrideArtifactName (102.77s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_NamespaceType (103.01s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Packaging (103.39s)
--- PASS: TestAccAWSCodeBuildProject_Source_GitCloneDepth (65.89s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_Bitbucket (66.23s)
--- PASS: TestAccAWSCodeBuildProject_Source_InsecureSSL (66.16s)
--- PASS: TestAccAWSCodeBuildProject_BadgeEnabled (39.97s)
--- PASS: TestAccAWSCodeBuildProject_basic (50.47s)
--- PASS: TestAccAWSCodeBuildProject_EncryptionKey (75.25s)
--- PASS: TestAccAWSCodeBuildProject_Description (66.07s)
--- PASS: TestAccAWSCodeBuildProject_BuildTimeout (56.36s)
--- PASS: TestAccAWSCodeBuildProject_Environment_Certificate (63.04s)
--- PASS: TestAccAWSCodeBuildProject_Environment_EnvironmentVariable (94.04s)
--- PASS: TestAccAWSCodeBuildProject_VpcConfig (114.89s)
--- PASS: TestAccAWSCodeBuildProject_LogsConfig_CloudWatchLogs (77.52s)
--- PASS: TestAccAWSCodeBuildProject_Cache (144.25s)
--- PASS: TestAccAWSCodeBuildProject_LogsConfig_S3Logs (140.35s)
FAIL
FAIL    github.com/terraform-providers/terraform-provider-aws/aws       200.834s
make: *** [testacc] Error 1

make testacc TESTARGS="-run=TestAccAWSCodeDeployDeploymentGroup_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSCodeDeployDeploymentGroup_basic -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSCodeDeployDeploymentGroup_basic
=== PAUSE TestAccAWSCodeDeployDeploymentGroup_basic
=== RUN   TestAccAWSCodeDeployDeploymentGroup_basic_tagSet
=== PAUSE TestAccAWSCodeDeployDeploymentGroup_basic_tagSet
=== CONT  TestAccAWSCodeDeployDeploymentGroup_basic
=== CONT  TestAccAWSCodeDeployDeploymentGroup_basic_tagSet
--- PASS: TestAccAWSCodeDeployDeploymentGroup_basic (73.56s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_basic_tagSet (73.98s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       75.095s

make testacc TESTARGS="-run=TestAccAWSCodePipeline"                    
--- PASS: TestAccAWSCodePipelineWebhook_unauthenticated (23.74s)
--- PASS: TestAccAWSCodePipeline_emptyArtifacts (26.00s)
--- PASS: TestAccAWSCodePipeline_deployWithServiceRole (26.59s)
--- PASS: TestAccAWSCodePipelineWebhook_basic (29.19s)
--- PASS: TestAccAWSCodePipeline_basic (30.48s)
--- PASS: TestAccAWSCodePipeline_Import_basic (34.88s)
--- PASS: TestAccAWSCodePipelineWebhook_tags (37.40s)
--- PASS: TestAccAWSCodePipelineWebhook_ipAuth (37.46s)
--- PASS: TestAccAWSCodePipeline_tags (43.47s)

@ryndaniels ryndaniels requested a review from a team August 8, 2019 14:15
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/codebuild Issues and PRs that pertain to the codebuild service. service/codedeploy labels Aug 8, 2019
@ryndaniels ryndaniels added the bug Addresses a defect in current functionality. label Aug 8, 2019
bflad
bflad approved these changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

--- PASS: TestAccAWSCodeBuildProject_BadgeEnabled (32.14s)
--- PASS: TestAccAWSCodeBuildProject_basic (35.75s)
--- PASS: TestAccAWSCodeBuildProject_importBasic (36.10s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_CodeCommit (36.54s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_Bitbucket (37.14s)
--- PASS: TestAccAWSCodeBuildProject_Environment_Certificate (37.15s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_CodePipeline (29.90s)
--- PASS: TestAccAWSCodeBuildProject_Source_InsecureSSL (44.63s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_Bitbucket (46.41s)
--- PASS: TestAccAWSCodeBuildProject_Description (46.88s)
--- PASS: TestAccAWSCodeBuildProject_Source_GitCloneDepth (46.93s)
--- PASS: TestAccAWSCodeBuildProject_BuildTimeout (47.60s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHub (47.61s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHubEnterprise (47.66s)
--- PASS: TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Type (47.75s)
--- PASS: TestAWSCodeBuildProject_nameValidation (0.00s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_NoSourceInvalid (15.54s)
--- PASS: TestAccAWSCodeBuildProject_EncryptionKey (54.63s)
--- PASS: TestAccAWSCodeBuildProject_LogsConfig_CloudWatchLogs (54.74s)
--- PASS: TestAccAWSCodeBuildProject_LogsConfig_S3Logs (56.56s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_S3 (21.76s)
--- PASS: TestAccAWSCodeBuildProject_Environment_EnvironmentVariable (57.53s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_GitHubEnterprise (29.73s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_NoSource (29.55s)
--- PASS: TestAccAWSCodeBuildProject_WindowsContainer (27.56s)
--- PASS: TestAccAWSCodeBuildProject_Tags (36.14s)
--- PASS: TestAccAWSCodeBuildProject_Cache (77.53s)
--- PASS: TestAccAWSCodeBuildProject_SecondarySources_CodeCommit (30.42s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts (31.60s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_disappears (23.62s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_EncryptionDisabled (38.38s)
--- PASS: TestAccAWSCodeBuildProject_VpcConfig (49.73s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_NamespaceType (40.83s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Packaging (40.77s)
--- PASS: TestAccAWSCodeBuildProject_Environment_RegistryCredential (39.62s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_OverrideArtifactName (41.12s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Path (40.55s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_onPremiseTag (34.24s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_update (30.49s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_create (37.26s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_delete (32.01s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_basic (52.65s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_default (22.14s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_basic_tagSet (57.65s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_triggerConfiguration_multiple (59.24s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_update (29.99s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_targetGroupInfo_create (31.52s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_targetGroupInfo_update (30.40s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_create (42.50s)
--- PASS: TestAWSCodeDeployDeploymentGroup_buildTriggerConfigs (0.00s)
--- PASS: TestAWSCodeDeployDeploymentGroup_triggerConfigsToMap (0.00s)
--- PASS: TestAWSCodeDeployDeploymentGroup_buildAutoRollbackConfig (0.00s)
--- PASS: TestAWSCodeDeployDeploymentGroup_autoRollbackConfigToMap (0.00s)
--- PASS: TestAWSCodeDeployDeploymentGroup_expandDeploymentStyle (0.00s)
--- PASS: TestAWSCodeDeployDeploymentGroup_flattenDeploymentStyle (0.00s)
--- PASS: TestAWSCodeDeployDeploymentGroup_expandLoadBalancerInfo (0.00s)
--- PASS: TestAWSCodeDeployDeploymentGroup_flattenLoadBalancerInfo (0.00s)
--- PASS: TestAWSCodeDeployDeploymentGroup_expandBlueGreenDeploymentConfig (0.00s)
--- PASS: TestAWSCodeDeployDeploymentGroup_flattenBlueGreenDeploymentConfig (0.00s)
--- PASS: TestAWSCodeDeployDeploymentGroup_buildAlarmConfig (0.00s)
--- PASS: TestAWSCodeDeployDeploymentGroup_alarmConfigToMap (0.00s)
--- PASS: TestAWSCodeDeployDeploymentGroup_handleCodeDeployApiError (0.00s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_in_place_deployment_with_traffic_control_create (29.31s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_in_place_deployment_with_traffic_control_update (27.39s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_delete (45.30s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_create (50.86s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_autoRollbackConfiguration_disable (70.41s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_update (30.21s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_delete (62.32s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_loadBalancerInfo_targetGroupInfo_delete (50.95s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeployment_complete (29.76s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_delete (36.50s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_deploymentStyle_update (67.26s)
--- PASS: TestAccAWSCodePipeline_emptyArtifacts (30.43s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_triggerConfiguration_basic (107.62s)
--- PASS: TestAccAWSCodePipelineWebhook_basic (25.24s)
--- PASS: TestAccAWSCodePipeline_basic (39.26s)
--- PASS: TestAccAWSCodePipeline_tags (35.81s)
--- PASS: TestAccAWSCodePipelineWebhook_ipAuth (28.45s)
--- PASS: TestAccAWSCodePipeline_Import_basic (48.92s)
--- PASS: TestAccAWSCodePipelineWebhook_tags (34.36s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_update (115.44s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_delete (116.46s)
--- PASS: TestAccAWSCodePipelineWebhook_unauthenticated (47.83s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_create (125.29s)
--- PASS: TestAccAWSCodePipeline_deployWithServiceRole (70.28s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_alarmConfiguration_disable (126.52s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_update_with_asg (141.20s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_blueGreenDeploymentConfiguration_create (240.50s)
--- PASS: TestAccAWSCodeDeployDeploymentGroup_ECS_BlueGreen (254.95s)

@ryndaniels ryndaniels merged commit 6218a23 into master Aug 9, 2019
@ryndaniels ryndaniels deleted the rfd-retry-code branch August 9, 2019 09:42
@ryndaniels ryndaniels added this to the v2.24.0 milestone Aug 9, 2019
@ghost
Copy link

ghost commented Aug 15, 2019

This has been released in version 2.24.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
bug Addresses a defect in current functionality. service/codebuild Issues and PRs that pertain to the codebuild service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.24.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ryndaniels @bflad