Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final retries after timeouts creating, draining, and deleting ASGs and autoscaling helpers #9649

Merged
merged 1 commit into from
Aug 7, 2019
Merged

Final retries after timeouts creating, draining, and deleting ASGs and autoscaling helpers #9649

merged 1 commit into from
Aug 7, 2019

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #7873

Release note for CHANGELOG:

BUG FIXES:
* resource/aws_autoscaling_group: Final retries after timeouts creating, draining, and deleting ASGs and autoscaling helpers

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSAutoscalingLifecycleHook"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSAutoscalingLifecycleHook -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSAutoscalingLifecycleHook_basic
=== PAUSE TestAccAWSAutoscalingLifecycleHook_basic
=== RUN   TestAccAWSAutoscalingLifecycleHook_omitDefaultResult
=== PAUSE TestAccAWSAutoscalingLifecycleHook_omitDefaultResult
=== CONT  TestAccAWSAutoscalingLifecycleHook_basic
=== CONT  TestAccAWSAutoscalingLifecycleHook_omitDefaultResult
--- PASS: TestAccAWSAutoscalingLifecycleHook_omitDefaultResult (140.98s)
--- PASS: TestAccAWSAutoscalingLifecycleHook_basic (144.02s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       147.126s

make testacc TESTARGS="-run=TestAccAWSAutoScalingGroup"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSAutoScalingGroup -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSAutoScalingGroup_basic
=== PAUSE TestAccAWSAutoScalingGroup_basic
=== RUN   TestAccAWSAutoScalingGroup_namePrefix
=== PAUSE TestAccAWSAutoScalingGroup_namePrefix
=== RUN   TestAccAWSAutoScalingGroup_autoGeneratedName
=== PAUSE TestAccAWSAutoScalingGroup_autoGeneratedName
=== RUN   TestAccAWSAutoScalingGroup_terminationPolicies
=== PAUSE TestAccAWSAutoScalingGroup_terminationPolicies
=== RUN   TestAccAWSAutoScalingGroup_tags
=== PAUSE TestAccAWSAutoScalingGroup_tags
=== RUN   TestAccAWSAutoScalingGroup_VpcUpdates
=== PAUSE TestAccAWSAutoScalingGroup_VpcUpdates
=== RUN   TestAccAWSAutoScalingGroup_WithLoadBalancer
=== PAUSE TestAccAWSAutoScalingGroup_WithLoadBalancer
=== RUN   TestAccAWSAutoScalingGroup_WithLoadBalancer_ToTargetGroup
=== PAUSE TestAccAWSAutoScalingGroup_WithLoadBalancer_ToTargetGroup
=== RUN   TestAccAWSAutoScalingGroup_withPlacementGroup
=== PAUSE TestAccAWSAutoScalingGroup_withPlacementGroup
=== RUN   TestAccAWSAutoScalingGroup_enablingMetrics
=== PAUSE TestAccAWSAutoScalingGroup_enablingMetrics
=== RUN   TestAccAWSAutoScalingGroup_suspendingProcesses
=== PAUSE TestAccAWSAutoScalingGroup_suspendingProcesses
=== RUN   TestAccAWSAutoScalingGroup_withMetrics
=== PAUSE TestAccAWSAutoScalingGroup_withMetrics
=== RUN   TestAccAWSAutoScalingGroup_serviceLinkedRoleARN
=== PAUSE TestAccAWSAutoScalingGroup_serviceLinkedRoleARN
=== RUN   TestAccAWSAutoScalingGroup_ALB_TargetGroups
=== PAUSE TestAccAWSAutoScalingGroup_ALB_TargetGroups
=== RUN   TestAccAWSAutoScalingGroup_initialLifecycleHook
=== PAUSE TestAccAWSAutoScalingGroup_initialLifecycleHook
=== RUN   TestAccAWSAutoScalingGroup_ALB_TargetGroups_ELBCapacity
=== PAUSE TestAccAWSAutoScalingGroup_ALB_TargetGroups_ELBCapacity
=== RUN   TestAccAWSAutoScalingGroup_classicVpcZoneIdentifier
=== PAUSE TestAccAWSAutoScalingGroup_classicVpcZoneIdentifier
=== RUN   TestAccAWSAutoScalingGroup_emptyAvailabilityZones
=== PAUSE TestAccAWSAutoScalingGroup_emptyAvailabilityZones
=== RUN   TestAccAWSAutoScalingGroup_launchTemplate
=== PAUSE TestAccAWSAutoScalingGroup_launchTemplate
=== RUN   TestAccAWSAutoScalingGroup_launchTemplate_update
=== PAUSE TestAccAWSAutoScalingGroup_launchTemplate_update
=== RUN   TestAccAWSAutoScalingGroup_LaunchTemplate_IAMInstanceProfile
=== PAUSE TestAccAWSAutoScalingGroup_LaunchTemplate_IAMInstanceProfile
=== RUN   TestAccAWSAutoScalingGroup_MixedInstancesPolicy
=== PAUSE TestAccAWSAutoScalingGroup_MixedInstancesPolicy
=== RUN   TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandAllocationStrategy
=== PAUSE TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandAllocationStrategy
=== RUN   TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandBaseCapacity
=== PAUSE TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandBaseCapacity
=== RUN   TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandPercentageAboveBaseCapacity
=== PAUSE TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandPercentageAboveBaseCapacity
=== RUN   TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotAllocationStrategy
=== PAUSE TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotAllocationStrategy
=== RUN   TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotInstancePools
=== PAUSE TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotInstancePools
=== RUN   TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotMaxPrice
=== PAUSE TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotMaxPrice
=== RUN   TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_LaunchTemplateName
=== PAUSE TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_LaunchTemplateName
=== RUN   TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_Version
=== PAUSE TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_Version
=== RUN   TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_InstanceType
=== PAUSE TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_InstanceType
=== CONT  TestAccAWSAutoScalingGroup_basic
=== CONT  TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandAllocationStrategy
=== CONT  TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotAllocationStrategy
=== CONT  TestAccAWSAutoScalingGroup_launchTemplate_update
=== CONT  TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_InstanceType
=== CONT  TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_Version
=== CONT  TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_LaunchTemplateName
=== CONT  TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandBaseCapacity
=== CONT  TestAccAWSAutoScalingGroup_launchTemplate
=== CONT  TestAccAWSAutoScalingGroup_emptyAvailabilityZones
=== CONT  TestAccAWSAutoScalingGroup_classicVpcZoneIdentifier
=== CONT  TestAccAWSAutoScalingGroup_ALB_TargetGroups_ELBCapacity
=== CONT  TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandPercentageAboveBaseCapacity
=== CONT  TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotMaxPrice
=== CONT  TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotInstancePools
=== CONT  TestAccAWSAutoScalingGroup_initialLifecycleHook
=== CONT  TestAccAWSAutoScalingGroup_ALB_TargetGroups
=== CONT  TestAccAWSAutoScalingGroup_WithLoadBalancer
=== CONT  TestAccAWSAutoScalingGroup_VpcUpdates
=== CONT  TestAccAWSAutoScalingGroup_LaunchTemplate_IAMInstanceProfile
--- PASS: TestAccAWSAutoScalingGroup_classicVpcZoneIdentifier (55.22s)
=== CONT  TestAccAWSAutoScalingGroup_tags
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandAllocationStrategy (58.48s)
=== CONT  TestAccAWSAutoScalingGroup_terminationPolicies
--- PASS: TestAccAWSAutoScalingGroup_LaunchTemplate_IAMInstanceProfile (66.64s)
=== CONT  TestAccAWSAutoScalingGroup_autoGeneratedName
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_Version (82.50s)
=== CONT  TestAccAWSAutoScalingGroup_namePrefix
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_InstanceType (87.92s)
=== CONT  TestAccAWSAutoScalingGroup_MixedInstancesPolicy
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotAllocationStrategy (88.56s)
=== CONT  TestAccAWSAutoScalingGroup_suspendingProcesses
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_LaunchTemplateName (88.70s)
=== CONT  TestAccAWSAutoScalingGroup_serviceLinkedRoleARN
--- PASS: TestAccAWSAutoScalingGroup_launchTemplate (90.39s)
=== CONT  TestAccAWSAutoScalingGroup_WithLoadBalancer_ToTargetGroup
--- PASS: TestAccAWSAutoScalingGroup_emptyAvailabilityZones (97.20s)
=== CONT  TestAccAWSAutoScalingGroup_withMetrics
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandPercentageAboveBaseCapacity (115.72s)
=== CONT  TestAccAWSAutoScalingGroup_enablingMetrics
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotMaxPrice (121.95s)
=== CONT  TestAccAWSAutoScalingGroup_withPlacementGroup
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandBaseCapacity (121.99s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotInstancePools (122.14s)
--- PASS: TestAccAWSAutoScalingGroup_autoGeneratedName (57.13s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy (80.65s)
--- PASS: TestAccAWSAutoScalingGroup_namePrefix (88.08s)
--- PASS: TestAccAWSAutoScalingGroup_serviceLinkedRoleARN (85.41s)
--- PASS: TestAccAWSAutoScalingGroup_VpcUpdates (177.04s)
--- PASS: TestAccAWSAutoScalingGroup_launchTemplate_update (182.81s)
--- PASS: TestAccAWSAutoScalingGroup_withMetrics (89.99s)
--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups (196.67s)
--- PASS: TestAccAWSAutoScalingGroup_terminationPolicies (150.49s)
--- PASS: TestAccAWSAutoScalingGroup_initialLifecycleHook (237.09s)
--- PASS: TestAccAWSAutoScalingGroup_basic (249.62s)
--- PASS: TestAccAWSAutoScalingGroup_withPlacementGroup (183.08s)
--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups_ELBCapacity (314.25s)
--- PASS: TestAccAWSAutoScalingGroup_tags (295.27s)
--- PASS: TestAccAWSAutoScalingGroup_enablingMetrics (239.71s)
--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer (445.73s)
--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer_ToTargetGroup (375.11s)
--- PASS: TestAccAWSAutoScalingGroup_suspendingProcesses (395.45s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       485.653s

@ryndaniels ryndaniels requested a review from a team August 6, 2019 17:48
@ghost ghost added size/L Managed by automation to categorize the size of a PR. service/autoscaling Issues and PRs that pertain to the autoscaling service. labels Aug 6, 2019
@ryndaniels ryndaniels added the bug Addresses a defect in current functionality. label Aug 6, 2019
bflad
bflad approved these changes Aug 6, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

--- PASS: TestAccAWSAutoScalingGroup_namePrefix (49.52s)
--- PASS: TestAccAWSAutoScalingGroup_classicVpcZoneIdentifier (60.69s)
--- PASS: TestAccAWSAutoScalingGroup_launchTemplate (74.52s)
--- PASS: TestAccAWSAutoScalingGroup_serviceLinkedRoleARN (79.67s)
--- PASS: TestAccAWSAutoScalingGroup_emptyAvailabilityZones (93.67s)
--- PASS: TestAccAWSAutoScalingGroup_withMetrics (95.61s)
--- PASS: TestAccAWSAutoScalingGroup_autoGeneratedName (107.68s)
--- PASS: TestAccAWSAutoScalingGroup_launchTemplate_update (110.36s)
--- PASS: TestAccAWSAutoScalingGroup_terminationPolicies (116.11s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandAllocationStrategy (62.18s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy (78.88s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotAllocationStrategy (45.51s)
--- PASS: TestCapacitySatisfiedCreate (0.00s)
--- PASS: TestCapacitySatisfiedUpdate (0.00s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotInstancePools (43.63s)
--- PASS: TestAccAWSAutoScalingGroup_LaunchTemplate_IAMInstanceProfile (103.04s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandBaseCapacity (76.62s)
--- PASS: TestAccAWSAutoScalingGroup_enablingMetrics (165.36s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandPercentageAboveBaseCapacity (73.52s)
--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups (171.41s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_LaunchTemplateName (55.98s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_InstanceType (47.97s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_Version (68.50s)
--- PASS: TestAccAWSAutoScalingGroup_withPlacementGroup (211.21s)
--- PASS: TestAccAWSAutoScalingGroup_initialLifecycleHook (212.99s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotMaxPrice (107.59s)
--- PASS: TestAccAWSAutoScalingGroup_VpcUpdates (221.66s)
--- PASS: TestAccAWSAutoScalingGroup_tags (237.14s)
--- PASS: TestAccAWSAutoScalingGroup_suspendingProcesses (243.42s)
--- PASS: TestAccAWSAutoscalingLifecycleHook_basic (108.68s)
--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups_ELBCapacity (257.91s)
--- PASS: TestAccAWSAutoscalingLifecycleHook_omitDefaultResult (133.35s)
--- PASS: TestAccAWSAutoScalingGroup_basic (329.62s)
--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer (428.78s)
--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer_ToTargetGroup (627.53s)

@bflad bflad added this to the v2.23.0 milestone Aug 6, 2019
@ryndaniels ryndaniels merged commit 3baacdc into master Aug 7, 2019
@ryndaniels ryndaniels deleted the rfd-retry-autoscaling branch August 7, 2019 12:37
@ghost
Copy link

ghost commented Aug 7, 2019

This has been released in version 2.23.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
bug Addresses a defect in current functionality. service/autoscaling Issues and PRs that pertain to the autoscaling service. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.23.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ryndaniels @bflad