Final retry after timeout deleting vpc

[ryndaniels]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #7873

Release note for CHANGELOG:

BUG FIXES:
* resource/aws_vpc: Final retry after timeout deleting VPC

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSVpc"       
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSVpc -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSVpc_coreMismatchedDiffs
=== PAUSE TestAccAWSVpc_coreMismatchedDiffs
=== RUN   TestAccAWSVpcEndpointConnectionNotification_importBasic
=== PAUSE TestAccAWSVpcEndpointConnectionNotification_importBasic
=== RUN   TestAccAWSVpcEndpointConnectionNotification_basic
=== PAUSE TestAccAWSVpcEndpointConnectionNotification_basic
=== RUN   TestAccAWSVpcEndpointRouteTableAssociation_basic
=== PAUSE TestAccAWSVpcEndpointRouteTableAssociation_basic
=== RUN   TestAccAWSVpcEndpointServiceAllowedPrincipal_basic
=== PAUSE TestAccAWSVpcEndpointServiceAllowedPrincipal_basic
=== RUN   TestAccAWSVpcEndpointService_basic
=== PAUSE TestAccAWSVpcEndpointService_basic
=== RUN   TestAccAWSVpcEndpointService_AllowedPrincipalsAndTags
=== PAUSE TestAccAWSVpcEndpointService_AllowedPrincipalsAndTags
=== RUN   TestAccAWSVpcEndpointService_removed
=== PAUSE TestAccAWSVpcEndpointService_removed
=== RUN   TestAccAWSVpcEndpointSubnetAssociation_basic
=== PAUSE TestAccAWSVpcEndpointSubnetAssociation_basic
=== RUN   TestAccAWSVpcEndpointSubnetAssociation_multiple
=== PAUSE TestAccAWSVpcEndpointSubnetAssociation_multiple
=== RUN   TestAccAWSVpcEndpoint_gatewayBasic
=== PAUSE TestAccAWSVpcEndpoint_gatewayBasic
=== RUN   TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicyAndTags
=== PAUSE TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicyAndTags
=== RUN   TestAccAWSVpcEndpoint_gatewayPolicy
=== PAUSE TestAccAWSVpcEndpoint_gatewayPolicy
=== RUN   TestAccAWSVpcEndpoint_interfaceBasic
=== PAUSE TestAccAWSVpcEndpoint_interfaceBasic
=== RUN   TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup
=== PAUSE TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup
=== RUN   TestAccAWSVpcEndpoint_interfaceNonAWSService
=== PAUSE TestAccAWSVpcEndpoint_interfaceNonAWSService
=== RUN   TestAccAWSVpcEndpoint_removed
=== PAUSE TestAccAWSVpcEndpoint_removed
=== RUN   TestAccAWSVpcPeeringConnectionOptions_importBasic
=== PAUSE TestAccAWSVpcPeeringConnectionOptions_importBasic
=== RUN   TestAccAWSVpcPeeringConnectionOptions_basic
=== PAUSE TestAccAWSVpcPeeringConnectionOptions_basic
=== RUN   TestAccAWSVpc_basic
=== PAUSE TestAccAWSVpc_basic
=== RUN   TestAccAWSVpc_disappears
=== PAUSE TestAccAWSVpc_disappears
=== RUN   TestAccAWSVpc_AssignGeneratedIpv6CidrBlock
=== PAUSE TestAccAWSVpc_AssignGeneratedIpv6CidrBlock
=== RUN   TestAccAWSVpc_Tenancy
=== PAUSE TestAccAWSVpc_Tenancy
=== RUN   TestAccAWSVpc_tags
=== PAUSE TestAccAWSVpc_tags
=== RUN   TestAccAWSVpc_update
=== PAUSE TestAccAWSVpc_update
=== RUN   TestAccAWSVpc_bothDnsOptionsSet
=== PAUSE TestAccAWSVpc_bothDnsOptionsSet
=== RUN   TestAccAWSVpc_DisabledDnsSupport
=== PAUSE TestAccAWSVpc_DisabledDnsSupport
=== RUN   TestAccAWSVpc_classiclinkOptionSet
=== PAUSE TestAccAWSVpc_classiclinkOptionSet
=== RUN   TestAccAWSVpc_classiclinkDnsSupportOptionSet
=== PAUSE TestAccAWSVpc_classiclinkDnsSupportOptionSet
=== CONT  TestAccAWSVpc_coreMismatchedDiffs
=== CONT  TestAccAWSVpc_classiclinkDnsSupportOptionSet
=== CONT  TestAccAWSVpc_basic
=== CONT  TestAccAWSVpcEndpointSubnetAssociation_basic
=== CONT  TestAccAWSVpc_classiclinkOptionSet
=== CONT  TestAccAWSVpc_DisabledDnsSupport
=== CONT  TestAccAWSVpc_bothDnsOptionsSet
=== CONT  TestAccAWSVpc_update
=== CONT  TestAccAWSVpc_tags
=== CONT  TestAccAWSVpc_Tenancy
=== CONT  TestAccAWSVpc_AssignGeneratedIpv6CidrBlock
=== CONT  TestAccAWSVpc_disappears
=== CONT  TestAccAWSVpcEndpointService_AllowedPrincipalsAndTags
=== CONT  TestAccAWSVpcEndpointService_removed
=== CONT  TestAccAWSVpcEndpointService_basic
=== CONT  TestAccAWSVpcEndpoint_interfaceBasic
=== CONT  TestAccAWSVpcEndpoint_gatewayPolicy
=== CONT  TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicyAndTags
=== CONT  TestAccAWSVpcEndpointServiceAllowedPrincipal_basic
=== CONT  TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup
=== CONT  TestAccAWSVpcEndpointRouteTableAssociation_basic
--- PASS: TestAccAWSVpc_disappears (31.09s)
--- PASS: TestAccAWSVpc_coreMismatchedDiffs (46.51s)
=== CONT  TestAccAWSVpcEndpointConnectionNotification_basic
--- PASS: TestAccAWSVpc_DisabledDnsSupport (56.13s)
=== CONT  TestAccAWSVpcEndpointConnectionNotification_importBasic
--- PASS: TestAccAWSVpc_basic (57.01s)
=== CONT  TestAccAWSVpcEndpoint_gatewayBasic
--- PASS: TestAccAWSVpc_bothDnsOptionsSet (57.52s)
=== CONT  TestAccAWSVpcPeeringConnectionOptions_importBasic
--- PASS: TestAccAWSVpc_classiclinkOptionSet (57.54s)
=== CONT  TestAccAWSVpcPeeringConnectionOptions_basic
--- PASS: TestAccAWSVpc_classiclinkDnsSupportOptionSet (58.10s)
=== CONT  TestAccAWSVpcEndpoint_removed
--- PASS: TestAccAWSVpc_update (82.90s)
=== CONT  TestAccAWSVpcEndpoint_interfaceNonAWSService
--- PASS: TestAccAWSVpc_tags (93.99s)
=== CONT  TestAccAWSVpcEndpointSubnetAssociation_multiple
--- PASS: TestAccAWSVpcEndpointRouteTableAssociation_basic (67.73s)
--- PASS: TestAccAWSVpcPeeringConnectionOptions_basic (57.88s)
--- PASS: TestAccAWSVpcEndpoint_gatewayPolicy (115.52s)
--- PASS: TestAccAWSVpcEndpoint_removed (58.61s)
--- PASS: TestAccAWSVpcPeeringConnectionOptions_importBasic (61.21s)
--- PASS: TestAccAWSVpcEndpoint_gatewayBasic (66.91s)
--- PASS: TestAccAWSVpcEndpoint_interfaceBasic (126.14s)
--- PASS: TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicyAndTags (129.04s)
--- PASS: TestAccAWSVpc_AssignGeneratedIpv6CidrBlock (132.47s)
--- PASS: TestAccAWSVpc_Tenancy (134.39s)
--- PASS: TestAccAWSVpcEndpointService_basic (302.04s)
--- PASS: TestAccAWSVpcEndpointService_removed (308.81s)
--- PASS: TestAccAWSVpcEndpointSubnetAssociation_basic (319.48s)
--- PASS: TestAccAWSVpcEndpointServiceAllowedPrincipal_basic (344.57s)
--- PASS: TestAccAWSVpcEndpointService_AllowedPrincipalsAndTags (356.51s)
--- PASS: TestAccAWSVpcEndpointConnectionNotification_importBasic (308.71s)
--- PASS: TestAccAWSVpcEndpointConnectionNotification_basic (327.90s)
--- PASS: TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup (446.38s)
--- PASS: TestAccAWSVpcEndpoint_interfaceNonAWSService (364.72s)
--- PASS: TestAccAWSVpcEndpointSubnetAssociation_multiple (729.57s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       824.733s

[bflad]

LGTM 🚀

--- PASS: TestAccAWSVpc_coreMismatchedDiffs (30.51s)
--- PASS: TestAccAWSVpc_disappears (11.81s)
--- PASS: TestAccAWSVpc_basic (41.89s)
--- PASS: TestAccAWSVpc_DisabledDnsSupport (14.89s)
--- PASS: TestAccAWSVpc_tags (30.03s)
--- PASS: TestAccAWSVpc_classiclinkOptionSet (15.81s)
--- PASS: TestAccAWSVpc_bothDnsOptionsSet (25.79s)
--- PASS: TestAccAWSVpc_update (31.29s)
--- PASS: TestAccAWSVpc_classiclinkDnsSupportOptionSet (12.50s)
--- PASS: TestAccAWSVpc_Tenancy (43.60s)
--- PASS: TestAccAWSVpc_AssignGeneratedIpv6CidrBlock (57.09s)

[ghost]

This has been released in version 2.23.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!