Final retries after timeouts creating and updating secrets

[ryndaniels]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #7873

Release note for CHANGELOG:

BUG FIXES
* resource/aws_secretsmanager_secret: Fianl retries after timeouts creating and updating secrets

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAwsSecretsManagerSecret"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAwsSecretsManagerSecret -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAwsSecretsManagerSecret_Basic
=== PAUSE TestAccAwsSecretsManagerSecret_Basic
=== RUN   TestAccAwsSecretsManagerSecret_withNamePrefix
=== PAUSE TestAccAwsSecretsManagerSecret_withNamePrefix
=== RUN   TestAccAwsSecretsManagerSecret_Description
=== PAUSE TestAccAwsSecretsManagerSecret_Description
=== RUN   TestAccAwsSecretsManagerSecret_KmsKeyID
=== PAUSE TestAccAwsSecretsManagerSecret_KmsKeyID
=== RUN   TestAccAwsSecretsManagerSecret_RecoveryWindowInDays_Recreate
=== PAUSE TestAccAwsSecretsManagerSecret_RecoveryWindowInDays_Recreate
=== RUN   TestAccAwsSecretsManagerSecret_RotationLambdaARN
=== PAUSE TestAccAwsSecretsManagerSecret_RotationLambdaARN
=== RUN   TestAccAwsSecretsManagerSecret_RotationRules
=== PAUSE TestAccAwsSecretsManagerSecret_RotationRules
=== RUN   TestAccAwsSecretsManagerSecret_Tags
=== PAUSE TestAccAwsSecretsManagerSecret_Tags
=== RUN   TestAccAwsSecretsManagerSecret_policy
=== PAUSE TestAccAwsSecretsManagerSecret_policy
=== RUN   TestAccAwsSecretsManagerSecretVersion_BasicString
=== PAUSE TestAccAwsSecretsManagerSecretVersion_BasicString
=== RUN   TestAccAwsSecretsManagerSecretVersion_Base64Binary
=== PAUSE TestAccAwsSecretsManagerSecretVersion_Base64Binary
=== RUN   TestAccAwsSecretsManagerSecretVersion_VersionStages
=== PAUSE TestAccAwsSecretsManagerSecretVersion_VersionStages
=== CONT  TestAccAwsSecretsManagerSecret_Basic
=== CONT  TestAccAwsSecretsManagerSecret_RotationRules
=== CONT  TestAccAwsSecretsManagerSecret_Tags
=== CONT  TestAccAwsSecretsManagerSecret_policy
=== CONT  TestAccAwsSecretsManagerSecret_RotationLambdaARN
=== CONT  TestAccAwsSecretsManagerSecret_RecoveryWindowInDays_Recreate
=== CONT  TestAccAwsSecretsManagerSecretVersion_BasicString
=== CONT  TestAccAwsSecretsManagerSecret_KmsKeyID
=== CONT  TestAccAwsSecretsManagerSecret_Description
=== CONT  TestAccAwsSecretsManagerSecretVersion_VersionStages
=== CONT  TestAccAwsSecretsManagerSecret_withNamePrefix
=== CONT  TestAccAwsSecretsManagerSecretVersion_Base64Binary
--- PASS: TestAccAwsSecretsManagerSecret_policy (28.54s)
--- PASS: TestAccAwsSecretsManagerSecret_withNamePrefix (31.63s)
--- PASS: TestAccAwsSecretsManagerSecret_Basic (31.90s)
--- PASS: TestAccAwsSecretsManagerSecretVersion_BasicString (32.40s)
--- PASS: TestAccAwsSecretsManagerSecretVersion_Base64Binary (32.55s)
--- PASS: TestAccAwsSecretsManagerSecret_Description (49.51s)
--- PASS: TestAccAwsSecretsManagerSecret_RecoveryWindowInDays_Recreate (61.49s)
--- PASS: TestAccAwsSecretsManagerSecretVersion_VersionStages (73.32s)
--- PASS: TestAccAwsSecretsManagerSecret_RotationLambdaARN (84.29s)
--- PASS: TestAccAwsSecretsManagerSecret_RotationRules (86.51s)
--- PASS: TestAccAwsSecretsManagerSecret_Tags (90.99s)
--- PASS: TestAccAwsSecretsManagerSecret_KmsKeyID (95.63s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       96.832s

[bflad]

LGTM 🚀

--- PASS: TestAccAwsSecretsManagerSecret_policy (11.27s)
--- PASS: TestAccAwsSecretsManagerSecret_withNamePrefix (11.59s)
--- PASS: TestAccAwsSecretsManagerSecret_Basic (11.66s)
--- PASS: TestAccAwsSecretsManagerSecretVersion_Base64Binary (12.55s)
--- PASS: TestAccAwsSecretsManagerSecretVersion_BasicString (12.65s)
--- PASS: TestAccAwsSecretsManagerSecret_Description (16.44s)
--- PASS: TestAccAwsSecretsManagerSecretVersion_VersionStages (20.43s)
--- PASS: TestAccAwsSecretsManagerSecret_RecoveryWindowInDays_Recreate (24.46s)
--- PASS: TestAccAwsSecretsManagerSecret_Tags (26.72s)
--- PASS: TestAccAwsSecretsManagerSecret_RotationRules (34.59s)
--- PASS: TestAccAwsSecretsManagerSecret_RotationLambdaARN (34.76s)
--- PASS: TestAccAwsSecretsManagerSecret_KmsKeyID (35.56s)

[ghost]

This has been released in version 2.23.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!