aws_s3_bucket_object : detect empty values at plan time

[vedsmand]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #9503

Release note for CHANGELOG:

added plan time validation for aws_s3_bucket_object on name and key properties

Output from acceptance testing:

--- PASS: TestAccAWSS3BucketObject_noNameNoKey (10.32s)
--- PASS: TestAccAWSS3BucketObject_contentBase64 (31.61s)
--- PASS: TestAccAWSS3BucketObject_source (31.76s)
--- PASS: TestAccAWSS3BucketObject_empty (32.56s)
--- PASS: TestAccAWSS3BucketObject_content (33.94s)
--- PASS: TestAccAWSS3BucketObject_sse (34.00s)
--- PASS: TestAccAWSS3BucketObject_withContentCharacteristics (35.71s)
--- PASS: TestAccAWSS3BucketObject_updates (49.25s)
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioning (52.65s)
--- PASS: TestAccAWSS3BucketObject_kms (53.75s)
--- PASS: TestAccAWSS3BucketObject_metadata (65.61s)
--- PASS: TestAccAWSS3BucketObject_acl (66.41s)
--- PASS: TestAccAWSS3BucketObject_tags (83.14s)
--- PASS: TestAccAWSS3BucketObject_tagsLeadingSlash (83.52s)
--- PASS: TestAccAWSS3BucketObject_storageClass (101.14s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       101.243s
...

[bflad]

Looks good, @vedsmand, thanks so much for adding the testing as well 🚀

--- PASS: TestAccAWSS3BucketObject_noNameNoKey (2.58s)
--- PASS: TestAccAWSS3BucketObject_withContentCharacteristics (14.73s)
--- PASS: TestAccAWSS3BucketObject_source (14.76s)
--- PASS: TestAccAWSS3BucketObject_sse (14.81s)
--- PASS: TestAccAWSS3BucketObject_empty (14.89s)
--- PASS: TestAccAWSS3BucketObject_contentBase64 (14.96s)
--- PASS: TestAccAWSS3BucketObject_content (15.07s)
--- PASS: TestAccAWSS3BucketObject_updates (21.34s)
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioning (21.67s)
--- PASS: TestAccAWSS3BucketObject_metadata (27.53s)
--- PASS: TestAccAWSS3BucketObject_acl (27.58s)
--- PASS: TestAccAWSS3BucketObject_tagsLeadingSlash (32.67s)
--- PASS: TestAccAWSS3BucketObject_kms (33.61s)
--- PASS: TestAccAWSS3BucketObject_tags (34.66s)
--- PASS: TestAccAWSS3BucketObject_storageClass (38.07s)

[ghost]

This has been released in version 2.23.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!