Final retries for timeouts on SFN objects

[ryndaniels]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #7873

Release note for CHANGELOG:

BUG FIXES
* resource/aws_sfn_activity: Retry after timeout deleting SFN activity
* resource/aws_sfn_state_machine: Retry after timeouts deleting and creating SFN state machines

Output from acceptance testing:

NOTE: Failure is long-standing due to eventual consistency of the DescribeStateMachine API call.


$ make testacc TESTARGS="-run=TestAccAWSSfnActivity"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSSfnActivity -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSSfnActivity_importBasic
=== PAUSE TestAccAWSSfnActivity_importBasic
=== RUN   TestAccAWSSfnActivity_basic
=== PAUSE TestAccAWSSfnActivity_basic
=== RUN   TestAccAWSSfnActivity_Tags
=== PAUSE TestAccAWSSfnActivity_Tags
=== CONT  TestAccAWSSfnActivity_importBasic
=== CONT  TestAccAWSSfnActivity_Tags
=== CONT  TestAccAWSSfnActivity_basic
--- PASS: TestAccAWSSfnActivity_basic (26.60s)
--- PASS: TestAccAWSSfnActivity_importBasic (30.09s)
--- PASS: TestAccAWSSfnActivity_Tags (68.38s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       69.481s

make testacc TESTARGS="-run=TestAccAWSSfnStateMachine"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSSfnStateMachine -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSSfnStateMachine_createUpdate
=== PAUSE TestAccAWSSfnStateMachine_createUpdate
=== RUN   TestAccAWSSfnStateMachine_Tags
=== PAUSE TestAccAWSSfnStateMachine_Tags
=== CONT  TestAccAWSSfnStateMachine_createUpdate
=== CONT  TestAccAWSSfnStateMachine_Tags
--- FAIL: TestAccAWSSfnStateMachine_createUpdate (66.91s)
    testing.go:568: Step 1 error: Check failed: Check 5/6 error: aws_sfn_state_machine.foo: Attribute 'definition' didn't match ".*\\\"MaxAttempts\\\": 10.*", got "{\n  \"Comment\": \"A Hello World example of the Amazon States Language using an AWS Lambda Function\",\n  \"StartAt\": \"HelloWorld\",\n  \"States\": {\n    \"HelloWorld\": {\n      \"Type\": \"Task\",\n      \"Resource\": \"arn:aws:lambda:us-west-2:187416307283:function:sfn-u0z61cbfcq\",\n      \"Retry\": [\n        {\n          \"ErrorEquals\": [\"States.ALL\"],\n          \"IntervalSeconds\": 5,\n          \"MaxAttempts\": 5,\n          \"BackoffRate\": 8.0\n        }\n      ],\n      \"End\": true\n    }\n  }\n}\n"
--- PASS: TestAccAWSSfnStateMachine_Tags (101.58s)
FAIL
FAIL    github.com/terraform-providers/terraform-provider-aws/aws       103.434s
make: *** [testacc] Error 1

[bflad]

LGTM 🚀 Test failure relating to eventual consistency known on master.

--- PASS: TestAccAWSSfnActivity_basic (7.55s)
--- PASS: TestAccAWSSfnActivity_importBasic (8.55s)
--- PASS: TestAccAWSSfnActivity_Tags (17.07s)
--- FAIL: TestAccAWSSfnStateMachine_createUpdate (31.11s)
--- PASS: TestAccAWSSfnStateMachine_Tags (39.95s)

[bflad]

This has been released in version 2.21.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests, documentation updates, or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!