resource/aws_db_instance: Redact MasterUserPassword when displaying InvalidParameterValue error with CreateDBInstance #9446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nvalidParameterValue error with CreateDBInstance
It was previously requested that the aws_db_instance Terraform resource show the given CreateDBInstance input configuration when receiving an `InvalidParameterValue` error. This would previously show the `MasterUserPassword` field of the input in the UI.
Previously before code update:
```
--- FAIL: TestAccAWSDBInstance_Password (5.84s)
testing.go:561: Step 0, expected error:
errors during apply: Error creating DB Instance: InvalidParameterValue: The parameter MasterUserPassword is not a valid password because it is shorter than 8 characters.
status code: 400, request id: 795895e7-8110-4460-9bf7-5211729522d9, {
AllocatedStorage: 5,
AutoMinorVersionUpgrade: true,
BackupRetentionPeriod: 0,
CopyTagsToSnapshot: false,
DBInstanceClass: "db.t2.micro",
DBInstanceIdentifier: "tf-acc-test-796357036994784624",
DBName: "",
DeletionProtection: false,
Engine: "mysql",
EngineVersion: "",
MasterUserPassword: "invalid",
MasterUsername: "tfacctest",
PubliclyAccessible: false,
StorageEncrypted: false,
Tags: []
}
To match:
MasterUserPassword: "\*{8}",
```
Output from acceptance testing after code update:
```
--- PASS: TestAccAWSDBInstance_Password (401.36s)
```
bflad
added
bug
ghost
added
size/S
ryndaniels
approved these changes
Jul 23, 2019
|
This has been released in version 2.21.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests, documentation updates, or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Release note for CHANGELOG:
It was previously requested that the
aws_db_instanceTerraform resource show the given CreateDBInstance input configuration when receiving anInvalidParameterValueerror. This would previously show theMasterUserPasswordfield of the input in the UI. The logic to show the input configuration has been present since version 1.23.0 of the Terraform AWS Provider.Previously before code update:
Output from acceptance testing after code update: