resource/aws_backup_selection: IAM retries, test fix, documentation updates to remove wildcard usage #9298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tency error Reference: #9297 Output from acceptance testing (failure present on master): ``` --- FAIL: TestAccAwsBackupSelection_withResources (12.00s) testing.go:568: Step 0 error: errors during apply: Error: error creating Backup Selection: InvalidParameterValueException: Invalid ARN: arn:aws:elasticfilesystem:us-west-2:--OMITTED--:file-system/. Specified resource is not supported status code: 400, request id: 2f845d03-51d3-48df-b853-46c077f85780 on /var/folders/v0/_d108fkx1pbbg4_sh864_7740000gn/T/tf-test308326165/main.tf line 22: (source code not available) --- PASS: TestAccAwsBackupSelection_disappears (17.20s) --- PASS: TestAccAwsBackupSelection_basic (18.44s) --- PASS: TestAccAwsBackupSelection_withTags (18.47s) --- PASS: TestAccAwsBackupSelection_updateTag (28.73s) ```
…ources acceptance test
The usage of wildcards differs between AWS Regions while ARNs are supported everywhere.
Previously from acceptance testing:
```
--- FAIL: TestAccAwsBackupSelection_withResources (12.00s)
testing.go:568: Step 0 error: errors during apply:
Error: error creating Backup Selection: InvalidParameterValueException: Invalid ARN: arn:aws:elasticfilesystem:us-west-2:--OMITTED--:file-system/. Specified resource is not supported
```
Output from acceptance testing:
```
--- PASS: TestAccAwsBackupSelection_withResources (29.35s)
```
…how IAM Role creation and show using resource ARNs The support for wildcard resource selection does not work in all AWS Regions while ARN support is consistent. Reference: #9269
bflad
added
bug
ghost
added
size/M
This was referenced Jul 10, 2019
nywilken
approved these changes
Jul 10, 2019
There was a problem hiding this comment.
LGTM 👍 👍
--- PASS: TestAccAwsBackupSelection_basic (26.50s)
--- PASS: TestAccAwsBackupSelection_withTags (26.82s)
--- PASS: TestAccAwsBackupSelection_disappears (55.71s)
--- PASS: TestAccAwsBackupSelection_withResources (67.02s)
--- PASS: TestAccAwsBackupSelection_updateTag (72.01s)
|
This has been released in version 2.19.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #9269
Closes #9297
Each commit has notes about the changes.
Release note for CHANGELOG:
Output from acceptance testing:
Output from acceptance testing (failure present on master):