add validation for route53 healthcheck request_interval

[nao23]

This patch proposes:

• add validation for request_interval of route53 healthcheck resource

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSRoute53HealthCheck_basic'

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSRoute53HealthCheck_basic -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSRoute53HealthCheck_basic
=== PAUSE TestAccAWSRoute53HealthCheck_basic
=== CONT  TestAccAWSRoute53HealthCheck_basic
--- PASS: TestAccAWSRoute53HealthCheck_basic (57.26s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	57.319s

[bflad]

Looks good, @nao23, thanks! 🚀 The Route 53 API documentation here is a little ambiguous with the acceptable values here:

Valid Range: Minimum value of 10. Maximum value of 30.

But with actually trying a value between the minimum and maximum, an error is returned referencing these two values so validation.IntInSlice() is in fact correct here. 👍

--- FAIL: TestAccAWSRoute53HealthCheck_basic (5.07s)
    testing.go:568: Step 0 error: errors during apply:

        Error: InvalidInput: Invalid XML ; cvc-enumeration-valid: Value '29' is not facet-valid with respect to enumeration '[10, 30]'. It must be a value from the enumeration.

Output from acceptance testing:

--- PASS: TestAccAWSRoute53HealthCheck_withHealthCheckRegions (12.97s)
--- PASS: TestAccAWSRoute53HealthCheck_CloudWatchAlarmCheck (13.35s)
--- PASS: TestAccAWSRoute53HealthCheck_IpConfig (14.97s)
--- PASS: TestAccAWSRoute53HealthCheck_basic (19.24s)
--- PASS: TestAccAWSRoute53HealthCheck_withSearchString (21.05s)
--- PASS: TestAccAWSRoute53HealthCheck_withSNI (23.85s)
--- PASS: TestAccAWSRoute53HealthCheck_withChildHealthChecks (25.64s)

[bflad]

This has been released in version 2.17.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!