Feature/fix removed resource error handling for aws cloudwatch event permission resource

[teraken0509]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #9025

Release note for CHANGELOG:

Bug Fix
- resource/aws_cloudwatch_event_permission: fix error handling when resource already removed.

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSCloudWatchEventPermission_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSCloudWatchEventPermission_ -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSCloudWatchEventPermission_Basic
=== PAUSE TestAccAWSCloudWatchEventPermission_Basic
=== RUN   TestAccAWSCloudWatchEventPermission_Action
=== PAUSE TestAccAWSCloudWatchEventPermission_Action
=== RUN   TestAccAWSCloudWatchEventPermission_Condition
=== PAUSE TestAccAWSCloudWatchEventPermission_Condition
=== RUN   TestAccAWSCloudWatchEventPermission_Multiple
=== PAUSE TestAccAWSCloudWatchEventPermission_Multiple
=== RUN   TestAccAWSCloudWatchEventPermission_Disappears
=== PAUSE TestAccAWSCloudWatchEventPermission_Disappears
=== CONT  TestAccAWSCloudWatchEventPermission_Basic
=== CONT  TestAccAWSCloudWatchEventPermission_Multiple
=== CONT  TestAccAWSCloudWatchEventPermission_Disappears
=== CONT  TestAccAWSCloudWatchEventPermission_Action
=== CONT  TestAccAWSCloudWatchEventPermission_Condition
--- PASS: TestAccAWSCloudWatchEventPermission_Action (35.66s)
--- PASS: TestAccAWSCloudWatchEventPermission_Multiple (50.37s)
--- PASS: TestAccAWSCloudWatchEventPermission_Condition (53.14s)
--- PASS: TestAccAWSCloudWatchEventPermission_Basic (55.14s)
--- PASS: TestAccAWSCloudWatchEventPermission_Disappears (86.11s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	86.216s

[bflad]

Whoops I'll fix this. 😅

aws/resource_aws_ses_identity_policy_test.go:98:6: `testAccCheckAwsSESIdentityPolicyDestroy` is unused (deadcode)
func testAccCheckAwsSESIdentityPolicyDestroy(s *terraform.State) error {
     ^

[bflad]

Looks great, thanks so much, @kterada0509 🚀

--- PASS: TestAccAWSCloudWatchEventPermission_Action (12.12s)
--- PASS: TestAccAWSCloudWatchEventPermission_Basic (18.01s)
--- PASS: TestAccAWSCloudWatchEventPermission_Multiple (18.19s)
--- PASS: TestAccAWSCloudWatchEventPermission_Condition (18.29s)
--- PASS: TestAccAWSCloudWatchEventPermission_Disappears (70.26s)

[bflad]

This has been released in version 2.16.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!