aws_dms_endpoint mongo settings default case #8672

[richardjennings]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #8672

Release note for CHANGELOG:

Use AWS SDK DMS constants for default resource attribute configuration

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAwsDmsEndpoint'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAwsDmsEndpoint -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAwsDmsEndpointBasic
=== PAUSE TestAccAwsDmsEndpointBasic
=== RUN   TestAccAwsDmsEndpointS3
=== PAUSE TestAccAwsDmsEndpointS3
=== RUN   TestAccAwsDmsEndpointDynamoDb
=== PAUSE TestAccAwsDmsEndpointDynamoDb
=== RUN   TestAccAwsDmsEndpointMongoDb
=== PAUSE TestAccAwsDmsEndpointMongoDb
=== RUN   TestAccAwsDmsEndpointDocDB
=== PAUSE TestAccAwsDmsEndpointDocDB
=== CONT  TestAccAwsDmsEndpointBasic
=== CONT  TestAccAwsDmsEndpointDocDB
=== CONT  TestAccAwsDmsEndpointMongoDb
=== CONT  TestAccAwsDmsEndpointDynamoDb
=== CONT  TestAccAwsDmsEndpointS3
--- PASS: TestAccAwsDmsEndpointBasic (45.49s)
--- PASS: TestAccAwsDmsEndpointDocDB (45.80s)
--- PASS: TestAccAwsDmsEndpointDynamoDb (61.89s)
--- PASS: TestAccAwsDmsEndpointS3 (62.76s)
--- PASS: TestAccAwsDmsEndpointMongoDb (63.84s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       63.927s

[richardjennings]

Updated default resource configuration for DMS Mongo endpoints to use SDK constants for auth_type, auth_mechanism and nesting_level.

I manually verified the linked issue is resolved by this PR.

I changed the expectation for SCRAM_SHA_1 to scram-sha-1 in the resource_aws_dms_endpoint acceptance test due to change in behaviour reported: aws/aws-sdk-go#2522

[bflad]

Thanks so much for this fix, @richardjennings 🚀

Output from acceptance testing:

--- PASS: TestAccAwsDmsEndpointBasic (21.19s)
--- PASS: TestAccAwsDmsEndpointMongoDb (26.47s)
--- PASS: TestAccAwsDmsEndpointDynamoDb (41.71s)
--- PASS: TestAccAwsDmsEndpointS3 (42.88s)
--- PASS: TestAccAwsDmsEndpointDocDB (51.96s)

[bflad]

This has been released in version 2.13.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!