Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_kinesis_analytics_application: Add support for resource tags #8643

Conversation

teraken0509
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #8609

Release note for CHANGELOG:

r/aws_kinesis_analytics_application: Add support for resource tags

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSKinesisAnalyticsApplication_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSKinesisAnalyticsApplication_ -timeout 120m
=== RUN   TestAccAWSKinesisAnalyticsApplication_basic
=== PAUSE TestAccAWSKinesisAnalyticsApplication_basic
=== RUN   TestAccAWSKinesisAnalyticsApplication_update
=== PAUSE TestAccAWSKinesisAnalyticsApplication_update
=== RUN   TestAccAWSKinesisAnalyticsApplication_addCloudwatchLoggingOptions
=== PAUSE TestAccAWSKinesisAnalyticsApplication_addCloudwatchLoggingOptions
=== RUN   TestAccAWSKinesisAnalyticsApplication_updateCloudwatchLoggingOptions
=== PAUSE TestAccAWSKinesisAnalyticsApplication_updateCloudwatchLoggingOptions
=== RUN   TestAccAWSKinesisAnalyticsApplication_inputsKinesisFirehose
=== PAUSE TestAccAWSKinesisAnalyticsApplication_inputsKinesisFirehose
=== RUN   TestAccAWSKinesisAnalyticsApplication_inputsKinesisStream
=== PAUSE TestAccAWSKinesisAnalyticsApplication_inputsKinesisStream
=== RUN   TestAccAWSKinesisAnalyticsApplication_inputsAdd
=== PAUSE TestAccAWSKinesisAnalyticsApplication_inputsAdd
=== RUN   TestAccAWSKinesisAnalyticsApplication_inputsUpdateKinesisStream
=== PAUSE TestAccAWSKinesisAnalyticsApplication_inputsUpdateKinesisStream
=== RUN   TestAccAWSKinesisAnalyticsApplication_outputsKinesisStream
=== PAUSE TestAccAWSKinesisAnalyticsApplication_outputsKinesisStream
=== RUN   TestAccAWSKinesisAnalyticsApplication_outputsMultiple
=== PAUSE TestAccAWSKinesisAnalyticsApplication_outputsMultiple
=== RUN   TestAccAWSKinesisAnalyticsApplication_outputsAdd
=== PAUSE TestAccAWSKinesisAnalyticsApplication_outputsAdd
=== RUN   TestAccAWSKinesisAnalyticsApplication_outputsUpdateKinesisStream
=== PAUSE TestAccAWSKinesisAnalyticsApplication_outputsUpdateKinesisStream
=== RUN   TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Add
=== PAUSE TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Add
=== RUN   TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Create
=== PAUSE TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Create
=== RUN   TestAccAWSKinesisAnalyticsApplication_referenceDataSource
=== PAUSE TestAccAWSKinesisAnalyticsApplication_referenceDataSource
=== RUN   TestAccAWSKinesisAnalyticsApplication_referenceDataSourceUpdate
=== PAUSE TestAccAWSKinesisAnalyticsApplication_referenceDataSourceUpdate
=== RUN   TestAccAWSKinesisAnalyticsApplication_tags
=== PAUSE TestAccAWSKinesisAnalyticsApplication_tags
=== CONT  TestAccAWSKinesisAnalyticsApplication_basic
=== CONT  TestAccAWSKinesisAnalyticsApplication_updateCloudwatchLoggingOptions
=== CONT  TestAccAWSKinesisAnalyticsApplication_addCloudwatchLoggingOptions
=== CONT  TestAccAWSKinesisAnalyticsApplication_outputsMultiple
=== CONT  TestAccAWSKinesisAnalyticsApplication_referenceDataSourceUpdate
=== CONT  TestAccAWSKinesisAnalyticsApplication_referenceDataSource
=== CONT  TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Create
=== CONT  TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Add
=== CONT  TestAccAWSKinesisAnalyticsApplication_outputsUpdateKinesisStream
=== CONT  TestAccAWSKinesisAnalyticsApplication_inputsKinesisStream
=== CONT  TestAccAWSKinesisAnalyticsApplication_outputsKinesisStream
=== CONT  TestAccAWSKinesisAnalyticsApplication_inputsUpdateKinesisStream
=== CONT  TestAccAWSKinesisAnalyticsApplication_inputsAdd
=== CONT  TestAccAWSKinesisAnalyticsApplication_outputsAdd
=== CONT  TestAccAWSKinesisAnalyticsApplication_update
=== CONT  TestAccAWSKinesisAnalyticsApplication_inputsKinesisFirehose
=== CONT  TestAccAWSKinesisAnalyticsApplication_tags
--- PASS: TestAccAWSKinesisAnalyticsApplication_basic (42.06s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_update (63.75s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Create (65.60s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_referenceDataSource (70.75s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_addCloudwatchLoggingOptions (78.22s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_updateCloudwatchLoggingOptions (90.22s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Add (91.11s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_tags (111.11s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_referenceDataSourceUpdate (118.12s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsKinesisStream (123.64s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsMultiple (123.97s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsKinesisStream (124.08s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsAdd (149.84s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsAdd (151.57s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsKinesisFirehose (151.77s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsUpdateKinesisStream (225.97s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsUpdateKinesisStream (240.87s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	240.976s

@ghost ghost added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. labels May 15, 2019
@teraken0509 teraken0509 force-pushed the feature/add-support-resource-tags-for-aws_kinesis_analytics_application-resource branch from 86bf4bd to e2c55b7 Compare May 15, 2019 13:56
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/kinesisanalytics Issues and PRs that pertain to the kinesisanalytics service. labels May 15, 2019
@bflad bflad added this to the v2.11.0 milestone May 15, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @kterada0509, thanks! 🚀

Output from AWS Standard acceptance testing:

--- PASS: TestAccAWSKinesisAnalyticsApplication_basic (15.71s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_update (23.04s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_addCloudwatchLoggingOptions (30.30s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_referenceDataSource (36.35s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Create (39.97s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_tags (40.87s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Add (42.05s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_updateCloudwatchLoggingOptions (45.01s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_referenceDataSourceUpdate (62.68s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsKinesisStream (92.62s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsMultiple (93.03s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsKinesisStream (93.23s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsAdd (110.68s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsKinesisFirehose (114.52s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsAdd (114.57s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsUpdateKinesisStream (178.05s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsUpdateKinesisStream (206.12s)

@bflad bflad merged commit 46bc1f4 into hashicorp:master May 15, 2019
bflad added a commit that referenced this pull request May 15, 2019
@bflad
Copy link
Contributor

bflad commented May 17, 2019

This has been released in version 2.11.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@teraken0509 teraken0509 deleted the feature/add-support-resource-tags-for-aws_kinesis_analytics_application-resource branch March 5, 2020 14:04
@ghost
Copy link

ghost commented Mar 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/kinesisanalytics Issues and PRs that pertain to the kinesisanalytics service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

r/aws_kinesis_analytics_application: Add support for resource tags
2 participants