-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not retrieve EMR AD Domain Join User from AWS API #8559
Conversation
The AWS API returns ******** for the ADDomainJoinUser attribute, the same as for ADDomainJoinPassword, CrossRealmTrustPrincipalPassword, and KdcAdminPassword. This causes a terraform plan to always attempt to rebuild the cluster since the ad_domain_join_user attribute is seen as changing from ******** to what is specified and desired in the plan. This now configures EMR to not retrieve this attribute from the AWS APIs so that it doesn't always attempt to rebuild the cluster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, @joelthompson 🚀 Given #9129 I'd like to pull this in, even without the acceptance testing being 100% since I'm familiar with the code here. Post merge I'm going to ensure the documentation notes that Terraform cannot perform drift detection on these arguments just to clear up any confusion regarding that. 👍
This has been released in version 2.18.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
Still not working on 2.18.0 $ terraform version
Your version of Terraform is out of date! The latest version kerberos_attributes.0.ad_domain_join_user: "********" => "newvalue" (forces new resource) |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
The AWS API returns ******** for the ADDomainJoinUser attribute, the
same as for ADDomainJoinPassword, CrossRealmTrustPrincipalPassword, and
KdcAdminPassword. This causes a terraform plan to always attempt to
rebuild the cluster since the ad_domain_join_user attribute is seen as
changing from ******** to what is specified and desired in the plan.
This now configures EMR to not retrieve this attribute from the AWS APIs
so that it doesn't always attempt to rebuild the cluster.
Community Note
Release note for CHANGELOG:
Output from acceptance testing:
N/A: I didn't run the acceptance tests as it looks like there is any test behavior for this aspect of EMR, and spinning up EMR clusters