Update data_source_aws_db_instance.go #8317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
they missed resource id...
ghost
added
service/rds
bflad
reviewed
Apr 24, 2019
There was a problem hiding this comment.
Hi @Richard-Mathie 👋 Thanks for submitting this.
Could you please add the following so we can get this in?
- Add
resource.TestCheckResourceAttrSet("data.aws_db_instance.bar", "resource_id"),inTestAccAWSDbInstanceDataSource_basicto ensure we have testing covering this new attribute - Add documentation for this new attribute in the attributes section of
website/docs/d/db_instance.html.markdown:
* `resource_id` - The RDS Resource ID of this instance.
bflad
added
enhancement
bflad
added a commit
that referenced
this pull request
May 7, 2019
Output from acceptance testing: ``` --- PASS: TestAccAWSDbInstanceDataSource_basic (526.46s) ```
|
Hi @Richard-Mathie 👋 Since we haven't heard back from you, we implemented the pull request feedback in a followup commit. Thanks again. |
bflad
added a commit
that referenced
this pull request
May 7, 2019
|
This has been released in version 2.10.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
breathingdust
removed
the
waiting-response
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
missed resource id...
Community Note
Fixes #0000
Changes proposed in this pull request:
note I need to expose resource id for referring to db resources in IAM policies.